-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseDir option and pass-through to ecstatic #395
Conversation
Thanks for this PR, @idmontie. One concern, though, is that I fear it would encourage the wrong exceptions, such as "oh good! now What are your thoughts on avoiding that misconception? |
@BigBlueHat That's true, I didn't think about that. In my case, I'm emulating a production folder structure on my local system, so files are usually pushed up to a subdirectory on a server, while on my local machine, they simply live in a build folder. I can see where the confusion lies. Maybe I can update the documentation/options docs to reflect that the port will be used, even though the files may be served with a prefix. |
That use case makes sense. If you can make that clear enough in the docs, then this is probably worth having--certainly others face the same scenario. Thanks! |
Any ETA on this? I have the same use case and would really like to see this feature. |
That would be good if you want to test the page routing when you know it will be served on a subpath in the future. |
This comment has been minimized.
This comment has been minimized.
If someone wants to bring over the goodness (tests, readme, etc) from #294 and add it to this PR (or a separate on to replace them both), I do think this is a Good Thing and would like to get it added. |
Upgrade ecstatic to version 3.0.0. Use ecstatic's baseDir option to set a base directory. See http-party#390
…into add-base-dir
Alright, @idmontie's #395 and @jesseditson's #294 have a one-line difference. I'm going to go with #294 because it came first |
@thornjad This issue was closed, but neither of the PRs you mentioned were ever merged. As #294 (the one you said you'd go with) has gone stale with merge conflicts since then, I have rebased the it into #837. |
Can this be merged? We do need this feature. Thanks! |
Upgrade ecstatic to version 3.0.0. Use ecstatic's baseDir option
to set a base directory.
See #390