Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ekf localization #127

Merged
merged 18 commits into from
Jul 7, 2023
Merged

Ekf localization #127

merged 18 commits into from
Jul 7, 2023

Conversation

rafal-gorecki
Copy link
Contributor

bump::patch

macstepien
macstepien requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@macstepien macstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it would be nice to add more comments on why setting was chosen, where values come from

panther_driver/src/driver_node.py Outdated Show resolved Hide resolved
panther_driver/src/driver_node.py Outdated Show resolved Hide resolved
panther_bringup/config/imu_config.yaml Outdated Show resolved Hide resolved
panther_bringup/config/imu_config.yaml Outdated Show resolved Hide resolved
panther_bringup/config/ekf_config.yaml Outdated Show resolved Hide resolved
macstepien
macstepien requested changes Jul 7, 2023
View reviewed changes
panther_driver/src/driver_node.py Outdated Show resolved Hide resolved
panther_bringup/config/ekf_config.yaml Show resolved Hide resolved
panther_bringup/config/ekf_config.yaml Outdated Show resolved Hide resolved
panther_bringup/config/imu_config.yaml Outdated Show resolved Hide resolved
panther_bringup/config/imu_config.yaml Outdated Show resolved Hide resolved
panther_description/config/WH01.yaml Show resolved Hide resolved
panther_description/config/WH02.yaml Outdated Show resolved Hide resolved
rafal-gorecki and others added 4 commits July 7, 2023 11:54
@rafal-gorecki @macstepien
Update panther_bringup/config/ekf_config.yaml
f83e451 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki @macstepien
Update panther_bringup/config/imu_config.yaml
34842df 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki @macstepien
Update panther_bringup/config/imu_config.yaml
58cb931 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki
Sugestions
bbda672
macstepien
macstepien requested changes Jul 7, 2023
View reviewed changes
panther_description/config/WH01.yaml Outdated Show resolved Hide resolved
panther_description/config/WH02.yaml Outdated Show resolved Hide resolved
panther_description/config/WH04.yaml Outdated Show resolved Hide resolved
rafal-gorecki and others added 3 commits July 7, 2023 13:16
@rafal-gorecki @macstepien
Update panther_description/config/WH01.yaml
e51102f 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki @macstepien
Update panther_description/config/WH02.yaml
3a67543 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki @macstepien
Update panther_description/config/WH04.yaml
23c2bf1 
Co-authored-by: Maciej Stępień <maciek1284@outlook.com>
@rafal-gorecki rafal-gorecki merged commit 47778c4 into ros1 Jul 7, 2023
@rafal-gorecki rafal-gorecki deleted the ekf branch July 7, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkowalsk1 pkowalsk1 pkowalsk1 left review comments

@macstepien macstepien macstepien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafal-gorecki @macstepien @pkowalsk1