ROS 2 imu node #212
Merged
ROS 2 imu node #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkowalsk1
reviewed
Nov 23, 2023
| @@ -0,0 +1,44 @@ | |||
| imu_filter_node: | |||
There was a problem hiding this comment.
imu_config.yaml or imu.yaml? Considering other config in this pkg and other Husarion robots utilize ekf.yaml, etc., which one would you prefer?
There was a problem hiding this comment.
Good question. in ROS 1 all configs are named with _config. I assume we switch to not using it.
panther_bringup/launch/imu.launch.py
Outdated
|
|
||
| imu_container = ComposableNodeContainer( | ||
| name="imu_container", | ||
| namespace="", |
There was a problem hiding this comment.
Is it necessary? Won't they conflict if we add a namespace in bringup.launch later?
pkowalsk1
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.