Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 add components #277

Merged
merged 9 commits into from
May 15, 2024
Merged

Ros2 add components #277

merged 9 commits into from
May 15, 2024

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Apr 24, 2024

After adding components
husarion/ros_components_description#43

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@@ -0,0 +1,27 @@
# The uncomment content in this file is the minimal requirement for components configuration file.
Copy link
Contributor

@rafal-gorecki rafal-gorecki Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to panther_description ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good point. I was thinking about this. I put this the bringup because you choose your components at runtime let's say but maybe the default components components: [] should be in description.

What do you prefer?

Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

panther_description/urdf/panther.urdf.xacro Outdated Show resolved Hide resolved
@rafal-gorecki
Copy link
Contributor

There are also a few shortcomings that I suggest you fix immediately and add a few sprint points to your task.

  1. First of all, I don't see the point of tf_prefix and namespace, because they are duplicated everywhere. In components, I would only leave device_namespace.

  2. I would remove all topic arguments from the sensor because changing this parameter causes gz_bridge to not find the topic. Therefore, the change must be made in two places. Moreover, the need to remap a topic will be extremely rare and the user can always do it in launch.py

@delihus delihus requested a review from rafal-gorecki May 8, 2024 14:46
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@rafal-gorecki rafal-gorecki self-requested a review May 13, 2024 11:33
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add short info to Readme about new arg or how to launch it

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@rafal-gorecki rafal-gorecki self-requested a review May 14, 2024 08:18
@delihus delihus merged commit b055c85 into ros2 May 15, 2024
@delihus delihus deleted the ros2-add-components branch May 15, 2024 06:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants