Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression: Apktool tries to load unexpected framework packages #3181

Closed
IgorEisberg opened this issue Jul 20, 2023 · 3 comments · Fixed by #3187
Closed

[BUG] Regression: Apktool tries to load unexpected framework packages #3181

IgorEisberg opened this issue Jul 20, 2023 · 3 comments · Fixed by #3187
Labels
Milestone

Comments

@IgorEisberg
Copy link
Contributor

A new issue with 2.8.0 and 2.8.1-SNAPSHOT, whenever decompiling an APK, it now calls "getPackage" (and then "loadFrameworkPkg") on arbitrary IDs instead of just loading the framework packages the APK depends on.
Don't have much information about this, still investigating myself where those IDs are coming from, but here's a piece of logging I added to both 2.8.1-SNAPSHOT and 2.7.1-SNAPSHOT for an obvious demo:

(same APK, left is 2.8.1-SNAPSHOT, right is 2.7.1-SNAPSHOT)
Apktool_2 8 0

@iBotPeaches
Copy link
Owner

cc @sv99 - might be related to recent refactors you did.

@iBotPeaches iBotPeaches added this to the v2.8.1 milestone Jul 20, 2023
@IgorEisberg
Copy link
Contributor Author

IgorEisberg commented Jul 20, 2023

One important point to mention, those unexpected getPackage/loadFrameworkPkg calls are happening between multiple stages while there are none of those calls in 2.7.1. If the output is saved to a file, it's a whopping 1.35MB of junk:
Apktool_2.8.1-SNAPSHOT.zip

@iBotPeaches
Copy link
Owner

Sorry @sv99 for the ping. Looks like I caused this with some attribute refactors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants