Prevent loading from resource pool if type is not a resolveable resource #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IgorEisberg - May you try this out and see if it resolves your issue? It should be an improvement from my last pr without leading to hammering framework calls with bs values. |
|
@iBotPeaches Indeed, the problem seems to be properly eliminated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing I noticed that we were attempting to resolve any value from the resource pool and string pool. This doesn't makes sense all the time for the resource pool for all types. For example, if we got a type float (
0x04) we'd cast it and shift it to resourceId from the local package. It might/might-not find a resource - thankfully it was always wrong so it didn't win out. It was however inefficient.