Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert change that broke loading framework packages #3185

Closed
wants to merge 1 commit into from
Closed

fix: revert change that broke loading framework packages #3185

wants to merge 1 commit into from

Conversation

IgorEisberg
Copy link
Contributor

The changes made in ResAttrDecoder.java were reverted as they break loading framework packages during decompilation.
This fixes #3181.

Added minor redundancy cleaning as a bonus.

@iBotPeaches
Copy link
Owner

Okay thanks for the find. This looks like it reverts a regression, but also reverts a fix. So I want to use your baseboard of a find to dig into what happened here of chain loading the packages from presumed wrong pkgIds.

@iBotPeaches
Copy link
Owner

Okay I did some peeking and I must have been drinking on the last patch I did to that area. I'm lost as to why I included attribute resolution for resIds for the VALUE.

This code even prior to my fix was calling out to the resource table constantly - it just was shifting and lying about its resourceId to the current package, thus avoiding that rapid call out that you noticed when I removed it.

There must be a situation (so I gotta find an old ticket) - where obfuscation comes into play and we have to chase down a value back to the resource pool. So while you are presently today getting hammered with calls to framework pulls - it was always happening prior just being lied/skipped to current pkgId.

I am working on a long-term fix to properly adjust the parser without breaking private namespaces.

@iBotPeaches
Copy link
Owner

Closing as I merged #3187, which I believe resolves this. The other changes are unrelated and appear to be cs related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Regression: Apktool tries to load unexpected framework packages
2 participants