-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rep congjian #2058
base: devel
Are you sure you want to change the base?
New rep congjian #2058
Conversation
""" | ||
# Compute adjusted target #eq 71 | ||
UtarTilde = normalizedSenTar @ UparVar @ normalizedSenExp.T @ np.linalg.pinv(normalizedSenExp @ UparVar @ normalizedSenTar.T + UmesVar) @ Umes | ||
# back transform to parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This equation might have a bug. doesn't match equation 71 in the writeup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
|
||
@article{Epiney1, | ||
title={A Systematic Approach to Inform Experiment Design Through Modern Modeling and Simulation Methods}, | ||
author={Epiney, A and Rabiti, C and Davis, C}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reference does not indicate if it is a journal of conf proceeding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@ In, None | ||
@ Out, stat, object, Basic Statistic PostProcessor Object | ||
""" | ||
from .. import factory as ppFactory # delay import to allow definition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this import be moved to the beginning of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reverted the change. It can not moved to the beginning of the file since the class has not been initialized yet. We need to first initialize the PP class then we can import the factory.
sensMatr[i, j] = sensDict[senName][0]* datasets[inpVar].meanValue / datasets[outVar].meanValue | ||
return sensMatr | ||
|
||
def _computeMoments(self, datasets, features, targets): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have something already developed that does the same functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have similar functions inside Basic Statistics PP. However, it seems there is a more general issue in the developed post-processor. The probability weight is not considered in some functions. For example, the _computeMoments
function. I will open an issue for this to allow this PP to accept probability weight in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see issue #2196
@joshua-cogliati-inl It seems there is another issue with windows installation:
|
Job Mingw Test on 645644e : invalidated by @wangcj05 issue with installation, truststore is not installable because there are no viable options |
Job Test qsubs sawtooth on 645644e : invalidated by @wangcj05 |
Job Mingw Test on 645644e : invalidated by @wangcj05 |
Job Test qsubs sawtooth on 645644e : invalidated by @wangcj05 |
… modifying the input dataset
Job Test qsubs sawtooth on 6d7d77b : invalidated by @joshua-cogliati-inl failed in set python environment |
Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05 |
@mandd FYI, the tests are green for this PR. Please let me know if you have additional comments. |
Hi @mandd, I think this PR is ready for you to take another review. Could you take a look in the next two weeks? |
Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05 directory exists issue |
Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05 environment issue |
Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05 |
Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05 Diff tests/cluster_tests/test_mpiqsub_nosplit, not related to this PR |
@mandd @PaulTalbot-INL @dylanjm @yoshiurr-INL @GabrielSoto-INL Can any of you review this PR? Both Josh and I have contributions to this PR. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1650 and #1546
This PR will add a representativity calculations post-processor. This post-processor can be used to calculation similarities between prototype and full scale models/experiments, perform input data adjustment, and uncertainty reductions for full scale models/experiments.
Future development will enable this post-processor to accept probability weight coming from other Samplers, such as grid/LHS. See #2196
What are the significant changes in functionality due to this change request?
Implements the representativity theory through bias factors for validation purposes
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.