Added Tooltip border color and width support #917

fpplm · 2022-02-23T21:17:40Z

In other to improve the test coverage, we should remove the example directory because we don't want that also the example enter inside the scoring. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

…ter_test.dart

…t_painter_test.dart

…_chart_painter_test.dart

…y are abstract and data classes)

…pieChart badgeWidgets), imaNNeo#861

imaNNeo#857.

…ms on showing titles when min, max values are below than 1.0)

* feat: Introduce 'clipBubble' attribute to scatter chart. * fix: remove `clipBubble` attribute and implement `clipData` function in scatter chart. * added issue fix imaNNeo#897 to changelog. * modify clip equation to resolve border issue. Co-authored-by: prajwal27wiijii <prajwal@wiijii.co>

* Fix lineChart clipData issue with border, imaNNeo#898 * Update CHANGELOG.md

…zero (imaNNeo#894) * Fix getBestInitialIntervalValue() problem with values above or below zero, imaNNeo#893. * Add `baselineX` and `baselineY` property to all of our axis-based charts (Line, Bar, Scatter). default is zero, imaNNeo#893. * Remove all linux/flutter/ephemeral files from example directory * Update CHANGELOG.md, bar_chart.md, and line_chart.md * Update line_chart.md * Update CHANGELOG.md

…ings

… of publish pipeline here: https://github.com/imaNNeoFighT/fl_chart/runs/5162430955?check_suite_focus=true

imaNNeo · 2022-02-28T20:13:06Z

CHANGELOG.md

Why this line is changed?

imaNNeo · 2022-02-28T20:17:19Z

lib/src/chart/bar_chart/bar_chart_data.dart

@@ -642,6 +642,12 @@ class BarTouchTooltipData with EquatableMixin {
  /// The tooltip background color.
  final Color tooltipBgColor;

+  /// The tooltip border color.
+  final Color tooltipBorderColor;


I think it's better to have a BorderSide (which contains color and width) Instead of defining two variables.

imaNNeo · 2022-02-28T20:20:35Z

lib/src/chart/bar_chart/bar_chart_painter.dart

@@ -668,6 +672,10 @@ class BarChartPainter extends AxisChartPainter<BarChartData> {
        bottomLeft: radius,
        bottomRight: radius);
    _bgTouchTooltipPaint.color = tooltipData.tooltipBgColor;
+    if (tooltipData.tooltipBorderWidth > 0) {


Can you please check the opacity of color too here?
Because sometimes people set a transparent color, which we don't need to draw anything.
(Maybe it's better to have an extension function like borderSide.isVisible())

extension BorderSideExtension on BorderSide { bool isVisible() => color.opacity > 0 && width > 0; }

Please apply it to other places.

codecov · 2022-02-28T20:26:17Z

Codecov Report

Merging #917 (f566516) into dev (94e186c) will decrease coverage by 0.14%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##              dev     #917      +/-   ##
==========================================
- Coverage   80.99%   80.85%   -0.15%     
==========================================
  Files          32       32              
  Lines        3026     3050      +24     
==========================================
+ Hits         2451     2466      +15     
- Misses        575      584       +9

Impacted Files	Coverage Δ
lib/src/chart/bar_chart/bar_chart_painter.dart	`86.17% <62.50%> (-0.39%)`	⬇️
lib/src/chart/line_chart/line_chart_painter.dart	`80.15% <62.50%> (-0.19%)`	⬇️
...src/chart/scatter_chart/scatter_chart_painter.dart	`95.08% <62.50%> (-0.88%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e186c...f566516. Read the comment docs.

imaNNeo · 2022-03-11T20:10:43Z

Our branching approach has just changed. We had to remove the dev branch (Which was your base branch).
Check out our new branching approach here.

vincenzopalazzo and others added 30 commits January 16, 2022 23:37

ci: improve codecov configuration

a64bdf3

In other to improve the test coverage, we should remove the example directory because we don't want that also the example enter inside the scoring. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Add SOURCES.md

3bae7d1

Improve calculateGroupAndBarsPosition and drawBars deep test

d276a81

Add showTestCoverage function in Makefile

2b91ea5

Ignore base classes from test coverage

2ecbae7

Write unit test for drawGrid() of axisChartPainter in line_chart_pain…

1f62d2d

…ter_test.dart

Write unit test for drawBackground() of axisChartPainter in line_char…

e216369

…t_painter_test.dart

Write unit test for drawRangeAnnotation() of axisChartPainter in line…

696cc6c

…_chart_painter_test.dart

Ignore axis_chart_data and axis_chart from test coverage (because the…

2c83454

…y are abstract and data classes)

Ignore bar, line, pie, radar, scatter data classes from test coverage

98dd64d

Implement unit test for chart renderers

b839ebb

Write unit test for canvas_wrapper in canvas_wrapper_test.dart

7ff1f68

Write unit test for calculateRotationOffset

dcdf6e3

Improve renderers unit test

a84c94e

write some lerp unit tests

65b6d1b

Write bar_chart_extensions unit tests

ca2540a

Fix PieChart changing sections issue (we have disabled semantics for …

4d270fb

…pieChart badgeWidgets), imaNNeo#861

Fix LineChart width smaller width or height lower than 40, imaNNeo#869,

4c91920

imaNNeo#857.

Allow to show titles when axis diff is zero, imaNNeo#842, imaNNeo#879

332e1f1

Update SOURCES.md

e4567d3

Correct main.dart function

d98202d

Improve iteration over axis values logic (it solves some minor proble…

a0825af

…ms on showing titles when min, max values are below than 1.0)

Update SOURCES.md

db42e76

Update SOURCES.md

668b4d2

Make sample app compatible with Flutter 2.10

4917dc4

Update README.md

26c3f23

Remove branch before fetching in checkoutToPR makefile command

10867bf

Fix makefile checkoutToPR problem

20b417f

Fix lineChart clipData issue with border, imaNNeo#898 (imaNNeo#901)

16100e9

* Fix lineChart clipData issue with border, imaNNeo#898 * Update CHANGELOG.md

joeldomke and others added 15 commits February 11, 2022 23:56

Add custom distance function and order spots in LineTouchResponse

52b0faa

Add documentation and make small fix

445c032

Bump version to 0.45.0

21df887

Update mockito, and build_runner dependencies.

7d1f83d

Add .pubignore file to ignore tests, repo_files, example and other th…

f50800c

…ings

Remove .pubignore :/

566277f

Add vector_math in dev_dependencies to solve the dependency error…

f049571

… of publish pipeline here: https://github.com/imaNNeoFighT/fl_chart/runs/5162430955?check_suite_focus=true

Revert publish action to 1.3.1

e3ea89f

Update CHANGELOG.md

eab937b

Update README.md

42f89ea

Set interval 1 for line_chart_sample2 grid lines

a3e2e39

Set interval 1 for line_chart_sample5 bottom titles

cc3462a

Fix FlSpot.nullSpot at the first of list bug, imaNNeo#912.

94e186c

Added Tooltip border color and width support

f566516

fpplm mentioned this pull request Feb 24, 2022

Feature/add/tooltip border color #914

Closed

imaNNeo reviewed Feb 28, 2022

View reviewed changes

CHANGELOG.md

## 0.0.1 - Released on (2019 June 4)

Copy link

Owner

imaNNeo Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line is changed?

imaNNeo reviewed Feb 28, 2022

View reviewed changes

imaNNeo force-pushed the dev branch 2 times, most recently from 37fb6f1 to 711c937 Compare March 3, 2022 20:46

imaNNeo deleted the branch imaNNeo:dev March 11, 2022 19:57

imaNNeo closed this Mar 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Tooltip border color and width support #917

Added Tooltip border color and width support #917

fpplm commented Feb 23, 2022 •

edited by imaNNeo

Loading

imaNNeo Feb 28, 2022

imaNNeo Feb 28, 2022

fpplm Mar 1, 2022

imaNNeo Feb 28, 2022

imaNNeo Feb 28, 2022

codecov bot commented Feb 28, 2022

imaNNeo commented Mar 11, 2022

Added Tooltip border color and width support #917

Added Tooltip border color and width support #917

Conversation

fpplm commented Feb 23, 2022 • edited by imaNNeo Loading

imaNNeo Feb 28, 2022

Choose a reason for hiding this comment

imaNNeo Feb 28, 2022

Choose a reason for hiding this comment

fpplm Mar 1, 2022

Choose a reason for hiding this comment

imaNNeo Feb 28, 2022

Choose a reason for hiding this comment

imaNNeo Feb 28, 2022

Choose a reason for hiding this comment

codecov bot commented Feb 28, 2022

Codecov Report

imaNNeo commented Mar 11, 2022

fpplm commented Feb 23, 2022 •

edited by imaNNeo

Loading