[SYCL] Add buffer dimensions restriction #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, apply clang-format. |
sycl/include/CL/sycl/accessor.hpp
Outdated
| @@ -1250,7 +1251,7 @@ class accessor<DataT, Dimensions, AccessMode, access::target::image_array, | |||
| }; | |||
|
|
|||
| } // namespace sycl | |||
| } // __SYCL_INLINE_NAMESPACE(cl) | |||
| } // namespace cl | |||
There was a problem hiding this comment.
Please revert this change
sycl/include/CL/sycl/accessor.hpp
Outdated
Comment on lines
776
to
779
| template <int Dims = Dimensions, typename AllocatorT, | ||
| typename = typename detail::enable_if_t< | ||
| (Dims == 0) && | ||
| (!IsPlaceH && (IsGlobalBuf || IsConstantBuf))> | ||
| > |
There was a problem hiding this comment.
Is this code properly clang-formatted?
-Replacing "static_assetr" with "enable_if" for correct work with pointers -fixing some functions for correct "make sycl-check" Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
MochalovaAn
force-pushed
the
bufferRestriction2
branch
from
274e7d6 to
9197f4a
Compare
|
Please, apply clang-format to the patch |
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
|
The contents of the patch LGTM, but could you please fix the commit message? It seems that the description refers to the diff between this patch and its earlier version. |
romanovvlad
reviewed
Mar 3, 2020
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
sergey-semenov
approved these changes
Mar 10, 2020
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 13, 2020
…st_commit * otcshare/sycl: (469 commits) [SYCL] Implement thread-local storage restriction (intel#1281) [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278) [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129) [SYCL] Add buffer dimensions restriction (intel#1147) [SYCL][NFC] Update copyright header in handler files (intel#1271) [SYCL][NFC] Format the code with clang-format [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228) [SYCL][NFC] Fix doxygen warnings (intel#1270) [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268) [SYCL][NFC] Fix a misleading comment regarding the SYCL flow (intel#1266) Change capability for SpecId decoration README.md: Mention retrieving llvm archive signatures travis: Restore macOS builds ...
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 15, 2020
…_accessor_refactor * origin/sycl: (454 commits) [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129) [SYCL] Add buffer dimensions restriction (intel#1147) [SYCL][NFC] Update copyright header in handler files (intel#1271) [SYCL][NFC] Format the code with clang-format [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228) [SYCL][NFC] Fix doxygen warnings (intel#1270) [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268) Change capability for SpecId decoration README.md: Mention retrieving llvm archive signatures travis: Restore macOS builds Fix DebugInfo creation after LLVM change 7a42bab Add more missing mixes Add missing fixes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, a buffer can have dimensions of only 1, 2, and 3. In the old version, "static_assert" was used to limit it, which did not throw an exception when creating a pointer to a buffer with an incorrect dimension. In this patch it is impossible to create not only an object of the buffer class with incorrect dimensions, but also a link to it.
Also, constructor calls in the accessos class that tried to instantiate a buffer with a zero dimension were fixed.
Signed-off-by: amochalo anastasiya.mochalova@intel.com