[SYCL] Implement thread-local storage restriction, move vardecl checks #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL spec was recently clarified to prohibit thread local storage, so this commit ensures an error is always emitted in these cases. Additionally, the DeclRefExpr to a VarDecl were switched to delayed diagnostics. Signed-off-by: Erich Keane <erich.keane@intel.com>
premanandrao
previously approved these changes
Mar 10, 2020
Fznamznon
previously approved these changes
Mar 11, 2020
| @@ -0,0 +1,49 @@ | |||
| // RUN: %clang_cc1 -fsycl-is-device -verify -fsyntax-only -std=c++17 %s | |||
Out of curiosity, do you have a pointer to this ? |
|
OK, this is the oldest reference I can find in the SYCL-Docs public repository: KhronosGroup/SYCL-Docs@f714c21 . |
Yep, thats the reference I've implemented this based on. |
Also fixes up the issues found by the bots, including the lacking signed-off-by. Signed-off-by: Erich Keane <erich.keane@intel.com>
erichkeane
force-pushed
the
thread_local_prohibit
branch
from
2519573 to
bcbc2f1
Compare
|
Sorry about the force-push, the build bot failed me for a signed-off-by on my followup patch, so I had to update the commit message. Did everything there and mentioned by @Fznamznon |
Fznamznon
approved these changes
Mar 11, 2020
bader
approved these changes
Mar 11, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 12, 2020
…e_api_test * origin/sycl: [SYCL] Implement thread-local storage restriction (intel#1281) [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278)
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 13, 2020
…st_commit * otcshare/sycl: (469 commits) [SYCL] Implement thread-local storage restriction (intel#1281) [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278) [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129) [SYCL] Add buffer dimensions restriction (intel#1147) [SYCL][NFC] Update copyright header in handler files (intel#1271) [SYCL][NFC] Format the code with clang-format [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228) [SYCL][NFC] Fix doxygen warnings (intel#1270) [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268) [SYCL][NFC] Fix a misleading comment regarding the SYCL flow (intel#1266) Change capability for SpecId decoration README.md: Mention retrieving llvm archive signatures travis: Restore macOS builds ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL spec was recently clarified to prohibit thread local storage,
so this commit ensures an error is always emitted in these cases.
Additionally, the DeclRefExpr to a VarDecl were switched to delayed
diagnostics.
Signed-off-by: Erich Keane erich.keane@intel.com