Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time #1261

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 6, 2020

Install SYCL libraries and plugins to ${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX} rather than ${CMAKE_INSTALL_PREFIX}/lib.

@fwyzard fwyzard force-pushed the sycl_install_to_LLVM_LIBDIR_SUFFIX branch from 963fffe to b1016dc Compare March 6, 2020 09:06
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 6, 2020

Fixes part of #1229.

@bader bader linked an issue Mar 6, 2020 that may be closed by this pull request
@fwyzard

This comment has been minimized.

romanovvlad
romanovvlad previously approved these changes Mar 6, 2020
@fwyzard fwyzard force-pushed the sycl_install_to_LLVM_LIBDIR_SUFFIX branch from b1016dc to a5b5994 Compare March 6, 2020 13:20
@fwyzard

This comment has been minimized.

@fwyzard

This comment has been minimized.

@fwyzard

This comment has been minimized.

Install under lib${LLVM_LIBDIR_SUFFIX}/ rather tuna simply lib/
  - libsycl.so and its components
  - libpi_opencl.so
  - libpi_cuda.so
  - clc

Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
@fwyzard fwyzard force-pushed the sycl_install_to_LLVM_LIBDIR_SUFFIX branch from a5b5994 to 60c790a Compare March 9, 2020 19:36
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2020

rebased

@bader bader merged commit ba5ffb8 into intel:sycl Mar 10, 2020
@fwyzard fwyzard deleted the sycl_install_to_LLVM_LIBDIR_SUFFIX branch March 10, 2020 21:19
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 12, 2020
…e_api_test

* origin/sycl:
  [SYCL][NFC] Fix static code analysis concerns (intel#1283)
  [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277)
  [SYCL][CUDA] Implement the program kernel names query (intel#1248)
  [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261)
  [SYCL][UX] Diagnostic for undefined device functions (intel#1026)
  [SYCL] Reverse reqd_work_group_size attribute (intel#1234)
  [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249)
  [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129)
@bader bader added the cuda CUDA back-end label Mar 12, 2020
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Mar 13, 2020
…st_commit

* otcshare/sycl: (469 commits)
  [SYCL] Implement thread-local storage restriction (intel#1281)
  [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278)
  [SYCL][NFC] Fix static code analysis concerns (intel#1283)
  [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277)
  [SYCL][CUDA] Implement the program kernel names query (intel#1248)
  [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261)
  [SYCL][UX] Diagnostic for undefined device functions (intel#1026)
  [SYCL] Reverse reqd_work_group_size attribute (intel#1234)
  [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249)
  [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129)
  [SYCL] Add buffer dimensions restriction (intel#1147)
  [SYCL][NFC] Update copyright header in handler files (intel#1271)
  [SYCL][NFC] Format the code with clang-format
  [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228)
  [SYCL][NFC] Fix doxygen warnings (intel#1270)
  [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268)
  [SYCL][NFC] Fix a misleading comment regarding the SYCL flow (intel#1266)
  Change capability for SpecId decoration
  README.md: Mention retrieving llvm archive signatures
  travis: Restore macOS builds
  ...
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 15, 2020
…_accessor_refactor

* origin/sycl: (454 commits)
  [SYCL][NFC] Fix static code analysis concerns (intel#1283)
  [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277)
  [SYCL][CUDA] Implement the program kernel names query (intel#1248)
  [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261)
  [SYCL][UX] Diagnostic for undefined device functions (intel#1026)
  [SYCL] Reverse reqd_work_group_size attribute (intel#1234)
  [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249)
  [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129)
  [SYCL] Add buffer dimensions restriction (intel#1147)
  [SYCL][NFC] Update copyright header in handler files (intel#1271)
  [SYCL][NFC] Format the code with clang-format
  [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228)
  [SYCL][NFC] Fix doxygen warnings (intel#1270)
  [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268)
  Change capability for SpecId decoration
  README.md: Mention retrieving llvm archive signatures
  travis: Restore macOS builds
  Fix DebugInfo creation after LLVM change 7a42bab
  Add more missing mixes
  Add missing fixes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with make deploy-sycl-toolchain
3 participants