Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SPIR devicelib to toplevel. #1276

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Move SPIR devicelib to toplevel. #1276

merged 6 commits into from
Mar 19, 2020

Conversation

vzakhari
Copy link
Contributor

@vzakhari vzakhari commented Mar 9, 2020

Move devicelib out of llvm/sycl to the toplevel, so that projects beyond SYCL may use these sources to build their versions of devicelib.

@vzakhari
Copy link
Contributor Author

ping...

This is a blocker for my project. Can someone please approve this?

@bader bader requested a review from romanovvlad March 13, 2020 13:01
bader
bader previously approved these changes Mar 13, 2020
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

libdevice/CMakeLists.txt Outdated Show resolved Hide resolved
libdevice/CMakeLists.txt Outdated Show resolved Hide resolved
libdevice/device.h Show resolved Hide resolved
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for some reason the patch introduces regression, please fix.

Vyacheslav Zakharin added 6 commits March 18, 2020 14:51
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
Signed-off-by: Vyacheslav Zakharin <vyacheslav.p.zakharin@intel.com>
@vzakhari
Copy link
Contributor Author

LGTM, but for some reason the patch introduces regression, please fix.

Some recent changes in clang caused CL_SYCL_LANGUAGE_VERSION to be undefined. I had to add -sycl-std=2017 to options in SYCLLibdevice.cmake.

@bader bader merged commit a083318 into intel:sycl Mar 19, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 20, 2020
* sycl: (1209 commits)
  [SYCL] Check exit status get_device_count_by_type
  [SYCL][Doc] Update sub-group extension docs (intel#1330)
  [SYCL][Doc] Add leader to GroupAlgorithms (intel#1297)
  [SYCL] Add SYCL headers search path to default compilation options (intel#1347)
  [SYCL][PI] Add interoperability with generic handles to device and program classes (intel#1244)
  Move SPIR devicelib to top level (intel#1276)
  [SYCL][Driver] Improve fat static library support (intel#1319)
  [SYCL] Remove image_api LIT (intel#1349)
  [SYCL] Fix headers location for check-sycl-deploy target
  [SYCL] Allow gcc asm statements in kernel code (intel#1341)
  [SYCL] Add Intel FPGA force_pow2_depth attribute (intel#1284)
  [SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON (intel#1323)
  [SYCL][NFC] Fix execution graph dump (intel#1331)
  [SYCL][Doc] Release SYCL_INTEL_enqueue_barrier extension document (intel#1199)
  [SYCL][USM] Fix USM malloc_shared and free to handle zero byte (intel#1273)
  [SYCL] Fix undefined symbols in async_work_group_copy (intel#1243)
  [SYCL] Mark calls to barrier and work-item functions as convergent
  [SYCL][CUDA] Fix CUDA plug-in build with enabled assertions (intel#1325)
  [SYCL][Test] Add OpenCL requirement to test/ordered_queue/prop.cpp (intel#1335)
  [SYCL][CUDA] Improve CUDA backend documentation (intel#1293)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants