Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add Intel FPGA force_pow2_depth attribute #1284

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

mlychkov
Copy link
Contributor

This attribute provides explicit control over the geometry of memory
blocks used in a given memory system.

Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com

@mlychkov mlychkov requested review from MrSidims and vmaksimo March 11, 2020 10:30
@mlychkov mlychkov force-pushed the private/mlychkov/force_pow_2_attr branch 2 times, most recently from b752430 to 4c88512 Compare March 11, 2020 11:06
@MrSidims MrSidims requested a review from AGindinson March 11, 2020 11:09
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple doc-style nits:

clang/include/clang/Basic/AttrDocs.td Outdated Show resolved Hide resolved
clang/include/clang/Basic/AttrDocs.td Outdated Show resolved Hide resolved
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is LGTM.
Below I share some thoughts about some things that our implementation of declaration attributes is (IMHO) missing. Asking for a refactoring is too much for this PR, so you may resolve my comments right away without applying.

clang/include/clang/Basic/Attr.td Show resolved Hide resolved
clang/lib/Sema/SemaDeclAttr.cpp Show resolved Hide resolved
clang/lib/Sema/SemaDeclAttr.cpp Show resolved Hide resolved
MrSidims
MrSidims previously approved these changes Mar 11, 2020
This attribute provides explicit control over the geometry of memory
blocks used in a given memory system.

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@AGindinson AGindinson removed their assignment Mar 18, 2020
@romanovvlad romanovvlad merged commit fcadd26 into intel:sycl Mar 18, 2020
@mlychkov mlychkov deleted the private/mlychkov/force_pow_2_attr branch March 19, 2020 08:18
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 20, 2020
* sycl: (1209 commits)
  [SYCL] Check exit status get_device_count_by_type
  [SYCL][Doc] Update sub-group extension docs (intel#1330)
  [SYCL][Doc] Add leader to GroupAlgorithms (intel#1297)
  [SYCL] Add SYCL headers search path to default compilation options (intel#1347)
  [SYCL][PI] Add interoperability with generic handles to device and program classes (intel#1244)
  Move SPIR devicelib to top level (intel#1276)
  [SYCL][Driver] Improve fat static library support (intel#1319)
  [SYCL] Remove image_api LIT (intel#1349)
  [SYCL] Fix headers location for check-sycl-deploy target
  [SYCL] Allow gcc asm statements in kernel code (intel#1341)
  [SYCL] Add Intel FPGA force_pow2_depth attribute (intel#1284)
  [SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON (intel#1323)
  [SYCL][NFC] Fix execution graph dump (intel#1331)
  [SYCL][Doc] Release SYCL_INTEL_enqueue_barrier extension document (intel#1199)
  [SYCL][USM] Fix USM malloc_shared and free to handle zero byte (intel#1273)
  [SYCL] Fix undefined symbols in async_work_group_copy (intel#1243)
  [SYCL] Mark calls to barrier and work-item functions as convergent
  [SYCL][CUDA] Fix CUDA plug-in build with enabled assertions (intel#1325)
  [SYCL][Test] Add OpenCL requirement to test/ordered_queue/prop.cpp (intel#1335)
  [SYCL][CUDA] Improve CUDA backend documentation (intel#1293)
  ...
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
The time limit for individual test is 10 minutes now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants