Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON #1323

Merged
merged 1 commit into from
Mar 18, 2020
Merged

[SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON #1323

merged 1 commit into from
Mar 18, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 15, 2020

Explicitly link llvm-spirv with the libLLVMSPIRVLib.a static library even if building LLVM/clang with -DLLVM_LINK_LLVM_DYLIB=ON .

@fwyzard
[SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON
e4af5fe 
Explicitly link llvm-spirv with the libLLVMSPIRVLib.a static library even if
building LLVM/clang with -DLLVM_LINK_LLVM_DYLIB=ON .

Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2020

This seems to fix #1322, though I don't know if that is the correct fix or just a workaround.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2020

@vladimirlaz @bader could you review this ?

@bader bader requested a review from AlexeySotkin March 15, 2020 11:15
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2020

Upstream PR: KhronosGroup/SPIRV-LLVM-Translator#458 .

@bader bader merged commit 19dc07b into intel:sycl Mar 18, 2020
@fwyzard fwyzard deleted the fwyzard/fix_issue_1322 branch March 18, 2020 13:59
@romanovvlad
Copy link
Contributor

romanovvlad commented Mar 18, 2020 •
edited
Loading

Upstream PR: KhronosGroup/SPIRV-LLVM-Translator#458 .

The patch is merged to Khronos repo. I think we should close the PR, the change will get to intel/llvm during next pull down. @vladimirlaz

UPD. :( Ok, the patch is merged, github has not show me that initially.

@bader
Copy link
Contributor

bader commented Mar 18, 2020

Upstream PR: KhronosGroup/SPIRV-LLVM-Translator#458 .

The patch is merged to Khronos repo. I think we should close the PR, the change will get to intel/llvm during next pull down. @vladimirlaz

UPD. :( Ok, the patch is merged, github has not show me that initially.

It will keep @fwyzard happy until @vladimirlaz is working on pulling Khronos patches.

alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 20, 2020
Merge branch 'sycl' into private/abatashe/host_accessor_refactor
a126789 
* sycl: (1209 commits)
  [SYCL] Check exit status get_device_count_by_type
  [SYCL][Doc] Update sub-group extension docs (intel#1330)
  [SYCL][Doc] Add leader to GroupAlgorithms (intel#1297)
  [SYCL] Add SYCL headers search path to default compilation options (intel#1347)
  [SYCL][PI] Add interoperability with generic handles to device and program classes (intel#1244)
  Move SPIR devicelib to top level (intel#1276)
  [SYCL][Driver] Improve fat static library support (intel#1319)
  [SYCL] Remove image_api LIT (intel#1349)
  [SYCL] Fix headers location for check-sycl-deploy target
  [SYCL] Allow gcc asm statements in kernel code (intel#1341)
  [SYCL] Add Intel FPGA force_pow2_depth attribute (intel#1284)
  [SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON (intel#1323)
  [SYCL][NFC] Fix execution graph dump (intel#1331)
  [SYCL][Doc] Release SYCL_INTEL_enqueue_barrier extension document (intel#1199)
  [SYCL][USM] Fix USM malloc_shared and free to handle zero byte (intel#1273)
  [SYCL] Fix undefined symbols in async_work_group_copy (intel#1243)
  [SYCL] Mark calls to barrier and work-item functions as convergent
  [SYCL][CUDA] Fix CUDA plug-in build with enabled assertions (intel#1325)
  [SYCL][Test] Add OpenCL requirement to test/ordered_queue/prop.cpp (intel#1335)
  [SYCL][CUDA] Improve CUDA backend documentation (intel#1293)
  ...
@fwyzard fwyzard mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@AlexeySotkin AlexeySotkin Awaiting requested review from AlexeySotkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @romanovvlad @bader