Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IA Toolbar gone missing! #4665

Closed
cdrini opened this issue Feb 23, 2021 · 6 comments · Fixed by #4666
Closed

IA Toolbar gone missing! #4665

cdrini opened this issue Feb 23, 2021 · 6 comments · Fixed by #4666
Assignees
@jdlrobson
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Feb 23, 2021

Evidence / Screenshot (if possible)

Where did it go?
image

Relevant url?

https://openlibrary.org

Details

  • Logged in (Y/N)? N
  • Browser type/version? FF85
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Seems like caused by this commit: 55a6a39

Stakeholders

@jdlrobson @drakene
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Affects: UI Issues with the web site's user interface. [managed] labels Feb 23, 2021
@jdlrobson
Copy link
Collaborator

Which toolbar are you referring to? Are you referring to the "view book on archive.org" in the screenshot or something else?

Is the HTML for this toolbar in the DOM and hidden via CSS or missing entirely?

Seems like caused by this commit: 55a6a39

Did you do a git blame to confirm this, or is this a guess based on recent changes?
I'm not sure how a change to the covers HTML could impact anything on the given Relevant url (homepage)

I should have some bandwidth to look at this today with some further informaiton.

@jdlrobson
Copy link
Collaborator

I'm guessing this is what you mean?:

Screen Shot 2021-02-23 at 12 08 12 PM

Running a git bisect now to see when this happened...

@tfmorris
Copy link
Contributor

I like the new look. Much cleaner than having two different "top" bars.

@cdrini
Copy link
Collaborator Author

cdrini commented Feb 23, 2021 •
edited
Loading

Yep that's the one. I added a temporary shim to production in openlibrary/templates/site/alert.html until we get a proper fix.

<style>#topNotice { display: block !important; }</style>

@jdlrobson
Copy link
Collaborator

Yep can confirm that 55a6a39 is the problem here (with git bisect)

The line here is the problem:
55a6a39

jdlrobson added a commit to jdlrobson/openlibrary that referenced this issue Feb 23, 2021
@jdlrobson
Drop redundant line
c962817 
There is no topNotice element on
/books/OL28775995M/Der_Todeskanal/manage-covers
or
/books/OL28775995M/Der_Todeskanal/add-cover

so there is no need to hide the element. This rule was copied across
from existing inline JS 55a6a39 but presumably relates to a time when
the Internet Archive header was rendered on these pages.

Fixes: internetarchive#4665
@jdlrobson jdlrobson mentioned this issue Feb 23, 2021
Merged
@jdlrobson
Copy link
Collaborator

Pushed fix. The line is no longer needed so yay to identifying and getting rid of more unnecessary cruft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdlrobson jdlrobson

Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop redundant line jdlrobson/openlibrary
3 participants
@tfmorris @jdlrobson @cdrini