Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop redundant line #4666

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Drop redundant line #4666

merged 1 commit into from
Feb 23, 2021

Conversation

jdlrobson
Copy link
Collaborator

There is no topNotice element on
/books/OL28775995M/Der_Todeskanal/manage-covers
or
/books/OL28775995M/Der_Todeskanal/add-cover

so there is no need to hide the element. This rule was copied across
from existing inline JS 55a6a39 but presumably relates to a time when
the Internet Archive header was rendered on these pages.

Fixes: #4665

Screenshot

Screen Shot 2021-02-23 at 12 21 13 PM

There is no topNotice element on
/books/OL28775995M/Der_Todeskanal/manage-covers
or
/books/OL28775995M/Der_Todeskanal/add-cover

so there is no need to hide the element. This rule was copied across
from existing inline JS 55a6a39 but presumably relates to a time when
the Internet Archive header was rendered on these pages.

Fixes: internetarchive#4665
@cdrini cdrini self-assigned this Feb 23, 2021
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed topNotice now shows on staging.openlibrary.org . Patch deploying JS changes is a little difficult, so going to leave my shim up for now, and this will get deploying later this week. Thanks for the speedy fix!

@cdrini cdrini merged commit ba0b052 into internetarchive:master Feb 23, 2021
@cdrini cdrini deleted the 4665 branch February 23, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IA Toolbar gone missing!
2 participants