-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Webserver settings not properly saved/derived if chosen web instance bound to single interface #145
Comments
As an FYI, a workaround is:
While this works, it shows a rather nasty problem that occurs when one adapter is reliant on another. There should be a more defined API/interface in place for configuration of such dependencies. |
@GermanBluefox ... I will fix this after #103 is merged. |
you just closed my ticket and marked it as a duplicate, but your workaround for me is not working because:
My issue is I actually cannot change my adress |
…erver-settings-not-properly-savedderived-if-chosen-web-instance-bound-to-single-interface #145 Add good.
For the record, this mechanism is rather clumsy because if one re-configures their web adapter interface settings it may mean that any Chromecast adapter using that will stop working until it too is re-configured. A slightly nicer way might be to remove the IP address option from the Chromecast adapter and have it work out the address to use by looking at web adapater and Chromecast device subnets (or some other logic?). |
- (mcm1957) changed: Testing gas been updsated to use node 16/18/20 - (mcm1957) changed: dependencies have been updated * (raintonr) YouTube videos are allowed now ([#75](#75)) * (raintonr) AppId has been added to status ([#151](#151)) * (raintonr) Saving has been corrected if web instance listens on only one address ([#145](#145))
- (mcm1957) changed: Testing has been updated to use node.js 16/18/20 - (mcm1957) changed: Dependencies have been updated * (raintonr) YouTube videos are allowed now ([#75](#75)) * (raintonr) AppId has been added to status ([#151](#151)) * (raintonr) Storing of webserver settings has been corrected if web instance listens on only one address ([#145](#145))
Contact Details
robin@rainton.com
What happened?
This Chromecast adapter has 1 or 2 drop configuration down values regarding web instances:
web.0
,web.1
, etc).I recently re-configured our IoB web instances to only listen on a single interface (good security practice).
What this means is that the Web server IP configuration option disappears and a null value is stored for
adapter.config.webServer
setting.As a result, trying to play local files (by setting the appropriate state) causes the error messages, 'Sorry, cannot play file', 'Please configure webserver settings first!' to be logged.
Adapter Version
3.1.0
JS-Controller Version
4.0.23
Node JS Version
v16.17.1
NPM Version
8.15.0
Operating System
Debian
Relevant log output
The text was updated successfully, but these errors were encountered: