Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow YouTube videos #75

Closed
thopark opened this issue Jun 23, 2020 · 16 comments
Closed

Allow YouTube videos #75

thopark opened this issue Jun 23, 2020 · 16 comments
Labels
enhancement

Comments

@thopark
Copy link

thopark commented Jun 23, 2020

This library seems to allow playing YouTube videos:
https://github.com/alxhotel/chromecast-api/blob/master/lib/device.js
Maybe the functionality could be integrated?
@raintonr
Copy link
Contributor

Do you mean you would like the ability to initiate the playing of YouTube video on the device in question? If so, yes, I would love that too!

How do you envisage this working? Perhaps a new state is required under media? playContent or something? This could be a read/write state into which URLs could be set. If the URL happens to be a YouTube site then the video ID should be extracted and played. Have a look at how https://github.com/skorokithakis/catt works. Something like that?

@thopark
Copy link
Author

thopark commented Apr 12, 2021

Yes, that's exactly what I had in mind.

@raintonr
Copy link
Contributor

Ah... actually there is already the player.url2play state so that needs updating to handle YouTube links correctly.

@angelnu
Copy link
Collaborator

angelnu commented Apr 12, 2021

I am not actively developing this plugin anymore - PRs are welcome.

The url2play handler is able to process special URLs so support for youtube could be added there.

FYI @GermanBluefox

@stale
Copy link

stale bot commented Aug 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix label Aug 26, 2021
@raintonr
Copy link
Contributor

Not stale, still useful.

@stale stale bot removed the wontfix label Aug 26, 2021
@stale
Copy link

stale bot commented Nov 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix label Nov 24, 2021
@raintonr
Copy link
Contributor

Yes. Still relevant.

@stale stale bot removed the wontfix label Nov 24, 2021
@raintonr raintonr mentioned this issue Dec 2, 2021
Closed
@maxpd1
Copy link

maxpd1 commented Dec 2, 2021

Thank you @raintonr didn't saw this topic before.

But yes. Playing YouTubeMusic songs would also be a great thing. URL structure is known. But I have the feeling some kind of authentication function is missing.

@raintonr
Copy link
Contributor

raintonr commented Dec 6, 2021

In a search for a working implementation have discovered neither of these two work:

https://github.com/xat/castv2-youtube
https://github.com/irfanhabib/youtube-castv2-client

However, this does work...

https://github.com/alxhotel/chromecast-api

... but looks like the IOB adapter would require a major re-write in order to use that.

I will look at a quick solution copying some of the code from the latter and see if that's workable.

raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Dec 6, 2021
@raintonr
iobroker-community-adapters#75 Copied YT code from https://github.com…
700fe6a 
…/alxhotel/chromecast-api Seems to work here
@raintonr
Copy link
Contributor

raintonr commented Dec 6, 2021

See PR #103

@maxpd1
Copy link

maxpd1 commented Dec 6, 2021

@raintonr did you test if it also works for YTM?

But nevertheless yesterday I also booked Spotify for known reasons.

raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Dec 6, 2021
@raintonr
iobroker-community-adapters#75 Update package.lock
bd091f7
@raintonr
Copy link
Contributor

raintonr commented Dec 6, 2021

@raintonr did you test if it also works for YTM?

Sorry, but I detest YTM. From what I can tell the video IDs should be interchangeable but who knows with that junk.

raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Dec 7, 2021
@raintonr
iobroker-community-adapters#75 Join YT session if possible
f8933fd
raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Nov 14, 2022
@raintonr
iobroker-community-adapters#75 Added youtube-remote dependency
eb649c8
raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Nov 14, 2022
@raintonr
iobroker-community-adapters#75 put _launch back
9b89015
raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Nov 14, 2022
@raintonr
iobroker-community-adapters#75 Put adapterName back
5580138
raintonr added a commit to raintonr/ioBroker.chromecast that referenced this issue Nov 14, 2022
@raintonr
iobroker-community-adapters#75 Formatting
5aeba08
raintonr added a commit that referenced this issue Jan 12, 2023
@raintonr
Merge pull request #103 from raintonr/master
8b09d55 
#75 Copied YT code from https://github.com/alxhotel/chromecast-api Se…
@raintonr
Copy link
Contributor

Fixed with #103.

raintonr added a commit that referenced this issue Jan 12, 2023
@raintonr
#75 Oops - forgot readme.
4330bf9
@maxpd1
Copy link

maxpd1 commented Jan 15, 2023

Hi @raintonr

does this fix mean, that we can also play videos on a home mini? (surely only the audio of them)

@raintonr
Copy link
Contributor

Why don't you try it and tell us. I suspect not.

mcm1957 added a commit that referenced this issue Jan 22, 2024
@mcm1957
chore: release v3.2.0-alpha.0
ef6bf76 
- (mcm1957) changed: Testing gas been updsated to use node 16/18/20
- (mcm1957) changed: dependencies have been updated
* (raintonr) YouTube videos are allowed now ([#75](#75))
* (raintonr) AppId has been added to status ([#151](#151))
* (raintonr) Saving has been corrected if web instance listens on only one address ([#145](#145))
mcm1957 added a commit that referenced this issue Jan 22, 2024
@mcm1957
chore: release v3.2.0
d1946fd 
- (mcm1957) changed: Testing has been updated to use node.js 16/18/20
- (mcm1957) changed: Dependencies have been updated
* (raintonr) YouTube videos are allowed now ([#75](#75))
* (raintonr) AppId has been added to status ([#151](#151))
* (raintonr) Storing of webserver settings has been corrected if web instance listens on only one address ([#145](#145))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thopark @raintonr @angelnu @maxpd1 @Jey-Cee