#75 Copied YT code from https://github.com/alxhotel/chromecast-api Se…

[raintonr]

Just what it says in the title :)

[Jey-Cee]

Hi @raintonr,

while i am now maintaining this repository & the castv2-player i came to your PR.
I think we should split your PR into two parts, the youtube lib and the adapter specific part.
The lib part seems to fit better in the player module and is usable for other projects they build on top of it.

Can/will you do this?

Greets
Jey Cee

[raintonr]

The lib part seems to fit better in the player module and is usable for other projects they build on top of it.

Yeah - I would be inclined to agree, but thought this would get us going for now. Besides, I just stole that code from another project, surely it would be for them to do the upstream additions they actually created? 😉

[Jey-Cee]

Have you made some additions to their code we can provide them?
I've looked into the original code and there was no changes since 2 years.

[raintonr]

Have you made some additions to their code we can provide them?

No. I just copied it (including a comment saying where it was copied from).

[Jey-Cee]

Ok, so will you split it?
If not it's ok for me and i will do it on my own.

[raintonr]

Ok, so will you split it? If not it's ok for me and i will do it on my own.

I don't really have much spare time, so if you don't mind taking care of this much appreciated.

[Apollon77]

@raintonr WOuld you please rebase your PR based on latest changes on master ... then we integrate it

[raintonr]

@raintonr WOuld you please rebase your PR based on latest changes on master ... then we integrate it

Isn't @Jey-Cee looking after this?

[Apollon77]

No, he is not maintaining the adapter anymore, so I am now

[GermanBluefox]

@raintonr Sorry the adapter was refactored. Could you please resolve the conflicts?

[raintonr]

Funnily enough I reinstalled the latest version yesterday, so yes, will do. Can't get to this until next week though.

[raintonr]

@GermanBluefox this all looks good here now.