-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#75 Copied YT code from https://github.com/alxhotel/chromecast-api Se… #103
#75 Copied YT code from https://github.com/alxhotel/chromecast-api Se… #103
Conversation
Hi @raintonr, while i am now maintaining this repository & the castv2-player i came to your PR. Can/will you do this? Greets |
Yeah - I would be inclined to agree, but thought this would get us going for now. Besides, I just stole that code from another project, surely it would be for them to do the upstream additions they actually created? 😉 |
Have you made some additions to their code we can provide them? |
No. I just copied it (including a comment saying where it was copied from). |
Ok, so will you split it? |
I don't really have much spare time, so if you don't mind taking care of this much appreciated. |
@raintonr WOuld you please rebase your PR based on latest changes on master ... then we integrate it |
No, he is not maintaining the adapter anymore, so I am now |
@raintonr Sorry the adapter was refactored. Could you please resolve the conflicts? |
Funnily enough I reinstalled the latest version yesterday, so yes, will do. Can't get to this until next week though. |
@GermanBluefox this all looks good here now. |
Just what it says in the title :)