Remove provider query manager #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
@@ Coverage Diff @@
## remove-content-routing-from-bitswap-network #536 +/- ##
==============================================================================
Coverage ? 65.31%
==============================================================================
Files ? 206
Lines ? 25244
Branches ? 0
==============================================================================
Hits ? 16488
Misses ? 7281
Partials ? 1475
|
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
efaeefb
to
3a493b8
Compare
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 5, 2024
Keeps in sync with: - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
hacdias
changed the base branch from
main
to
remove-content-routing-from-bitswap-network
Jorropo
changed the base branch from
remove-content-routing-from-bitswap-network
to
main
Jorropo
changed the base branch from
main
to
remove-content-routing-from-bitswap-network
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
1347809
to
28f6549
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
3a493b8
to
1fe051b
Compare
hacdias
reviewed
Jan 12, 2024
Comment on lines
+416
to
+418
| if span.IsRecording() { | ||
| span.SetAttributes(attribute.Stringer("cid", c)) | ||
| } |
There was a problem hiding this comment.
Can't this be done directly? AFAIK, it won't call .String unless it's indeed recording. I think it could indeed be more problematic if directly passed as a string and needed to encode it every time. But here it seems fine. Is there another reason?
There was a problem hiding this comment.
It literally always call .String instantly:
https://github.com/open-telemetry/opentelemetry-go/blob/98b32a6c3a87fbee5d34c063b9096f416b250897/attribute/kv.go#L85
// Stringer creates a new key-value pair with a passed name and a string
// value generated by the passed Stringer interface.
func Stringer(k string, v fmt.Stringer) KeyValue {
return Key(k).String(v.String())
}
hacdias
approved these changes
Jan 12, 2024
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
28f6549
to
301d5b5
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
1fe051b
to
bed8453
Compare
This was referenced Jan 16, 2024
Merged
Closed
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
301d5b5
to
d414841
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
bed8453
to
15661e4
Compare
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
d414841
to
5eb2dbc
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
15661e4
to
f3d731b
Compare
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
5eb2dbc
to
0cd80af
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
f3d731b
to
1c8b6c9
Compare
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
0cd80af
to
6740401
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
1c8b6c9
to
5104983
Compare
Closes: #172 See #172 (comment) too. providerQueryManager took care of: - Deduping multiple sessions doing find providers for the same CID. - limiting global find providers. None of which we care: - This is rare, if this happens it's fine to run the same query twice. If we care then we should make a deduping content router so we can inject it anywhere a content router is needed. - It's fine to allow one concurrent find peer per session. No need to limit this at 6 globally after that, it's a great way to stall nodes doing many queries.
Jorropo
force-pushed
the
remove-content-routing-from-bitswap-network
branch
from
6740401
to
2dbd42a
Compare
Jorropo
force-pushed
the
remove-provider-query-manager
branch
from
5104983
to
2e813d8
Compare
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 16, 2024
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
|
ProviderQueryManager has been moved and refactored sufficiently where we do not need this PR, and if we want to make changes like this in the future it should be done in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #535