blockservice: move to single unique struct and add WithContentBlocker option
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 15, 2024
|
Fails to build to due to upstream issues in tests. Gonna fix once we do a decision. |
Jorropo
force-pushed
the
blockservice-stop-using-NewWriteThrough-in-tests
branch
from
afd5403
to
b8ac21b
Compare
Jorropo
force-pushed
the
blockservice-unique
branch
from
12650a8
to
5e08a77
Compare
This was referenced Jan 15, 2024
Closed
Base automatically changed from
blockservice-stop-using-NewWriteThrough-in-tests
to
blockservice-opt
January 15, 2024 17:20
…r` option The idea is to have a THE blockservice object, this means we wont ever have an issue where multiple competitive features play poorly with each other due to how nested blockservices could do. Let's say we add multi-exchange based on content routing, do we want to have to handle the mess this could create with nested blockservices ? It implements features for ipfs-shipyard/nopfs#34.
Jorropo
force-pushed
the
blockservice-unique
branch
from
5e08a77
to
27a4b69
Compare
This was referenced Jan 16, 2024
|
We are going with #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first option to fix the blockservice mess here.
The idea is to have a THE blockservice object, this means we wont ever have an issue where multiple competitive features play poorly with each other due to how nested blockservices could do.
Let's say we add multi-exchange based on content routing, do we want to have to handle the mess this could create with nested blockservices ?
It implements features for ipfs-shipyard/nopfs#34
I'll add changelog if we decide this is the option we want to go with.