Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: add WithContentBlocker option #556

Closed

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

The goal is to help with ipfs-shipyard/nopfs#34.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8ac21b) 65.16% compared to head (5d0398e) 65.48%.
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   65.16%   65.48%   +0.31%     
==========================================
  Files         204      207       +3     
  Lines       25597    25654      +57     
==========================================
+ Hits        16681    16800     +119     
+ Misses       7433     7371      -62     
  Partials     1483     1483              
Files Coverage Δ
blockservice/blockservice.go 79.51% <91.66%> (+1.80%) ⬆️

... and 15 files with indirect coverage changes

@Jorropo Jorropo force-pushed the 01-15-blockservice_add_compiletime_guard_for_BoundedBlockService_on_the_blockservice_struct branch from 4d08813 to 98c3890 Compare January 15, 2024 07:55
Base automatically changed from 01-15-blockservice_add_compiletime_guard_for_BoundedBlockService_on_the_blockservice_struct to main January 15, 2024 07:57
@Jorropo Jorropo force-pushed the 01-15-blockservice_add_WithContentBlocker_option branch from ec8bcb6 to 7e0cfb1 Compare January 15, 2024 07:58
@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 15, 2024

I think we all agree that either #562 or #564 are better alternatives.

@Jorropo Jorropo closed this Jan 15, 2024
@Jorropo Jorropo deleted the 01-15-blockservice_add_WithContentBlocker_option branch January 15, 2024 17:35
@Jorropo Jorropo restored the 01-15-blockservice_add_WithContentBlocker_option branch January 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant