Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing type number for slider input right panel #3609

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Sep 9, 2024

Describe Your Changes

Sorry my bad, the value should be Number instead string

Context:
There was an issue with a feature build that was behind the update, where the application loaded a model with some string parameters that should have been numbers.

To reproduce:
Build from any commits prior to this fix and behind the update.
Input a number into any number input box
Chat with model
See the error

Screenshot 2024-09-09 at 16 30 50

Screenshot 2024-09-09 at 16 31 12

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Sep 9, 2024
@urmauur urmauur self-assigned this Sep 9, 2024
@louis-jan
Copy link
Contributor

louis-jan commented Sep 9, 2024

Context:

There was an issue with a feature build that was behind the update, where the application loaded a model with some string parameters that should have been numbers.

Previous updates:

The number input component tries to cast the value to a string to fix the issue where users can just input ',' as a decimal separator.

That would address the input behavior and display to be aligned using the decimal point as a separator.

But the update led to a major issue where the persisted value was not cast to a number accordingly, which was rejected by the inference engine.

With the fix

These changes will keep the same display and input behavior but cast the value to a number before persisting.

To reproduce:

  1. Build from any commits prior to this fix and behind the update.
  2. Input a number into any number input box
  3. Chat with model
  4. See the error

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit fe9936c into dev Sep 9, 2024
11 checks passed
@urmauur urmauur deleted the fix/missing-type-value-slider-input-right-panel branch September 9, 2024 09:46
@github-actions github-actions bot added this to the v.0.6.0 milestone Sep 9, 2024
@louis-jan
Copy link
Contributor

I will find a way to add tests for this case. For now please proceed until the next nightly build goes out. Which should affect a lot of users, but for now, only one case was able to be tested.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Barecheck - Code coverage report

Total: 49.7%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants