test: add tests to model settings's Slider Input #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
|
cc @dan-homebrew, regarding the test covers you mentioned. |
urmauur
approved these changes
Sep 10, 2024
louis-jan
commented
Sep 10, 2024
|
LGTU -> looks good to us 💚 |
Barecheck - Code coverage reportTotal: 54.09%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
dan-homebrew
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@louis-jan Can I verify the nature of this bug:
- Is it UI related, or related to out-of-bounds error on params?
- The tests seem to be UI-related
- Do we need corresponding out-of-bounds tests at the API level?
Yes @dan-homebrew there is 1 more PR to add cover persistence layer. E.g. where all data are gathered and persisted. And that one is even more important. |
|
For the context, cc @hiento09 |
louis-jan
force-pushed
the
chore/add-tests-to-model-settings-input-component
branch
from
e17c59b
to
8047ed6
Compare
louis-jan
deleted the
chore/add-tests-to-model-settings-input-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR is a follow-up fix for #3609, where users could get stuck when inputting a value to the model settings input component.
In this PR, it covers the case where users could get stuck in a broken state after inputting an invalid settings value and then force quitting the app immediately. This behavior is hard to reproduce but possible.
Rework web test configurations to resolve the collision between Jest Babel and Next Babel.
Tests have been added to cover such cases.
Context
We've received a broken app report while testing a feature build; after investigating, we found the root cause and fixed it. However, tests have not been added in this PR due to the incomplete setup.
This PR is to add tests but it turned out that there are missing cases to handle.
Related PRs
Self Checklist