fix: fix failing github action setup #1886
Conversation
jellyfin-bot
added
the
ci
|
Kudos, SonarCloud Quality Gate passed!
|
|
I don't understand what are you trying to accomplish with this PR, as workflows work perfectly. They are currently failing because Tauri is failing because there's a huge mismatch between the Rust versions and JS packages (check #1738 and #1770). As soon as viet gets merged and renovate dependencies go afterwards, I expect those to get fixed. Bear in mind that even there was a node version switch in vite (master is in 16, vite in 18) |
The lint and typechecking steps are actually currently failing on setup, and not on execution. I've updated the description to better explain this. Check the failure result of the Typecheck and Lint steps for any recent PR to verify. |
aweebs
changed the title
|
@ferferga bumping this, I've updated the description to include the reason for it |
|
@aweebs Just updated the checklist of the main PR to include this: #1812 I just finished testing the new setup-node update and the issue is also present in master. They've been breaking workspaces in every major npm update lately, so this doesn't surprise me. |
ferferga
force-pushed
the
vite
branch
6 times, most recently
from
7a71b7b
to
f05baf9
Compare
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
|
You have successfully added a new CodeQL configuration |
ferferga
force-pushed
the
build_fixes
branch
3 times, most recently
from
00ae112
to
300e661
Compare
Co-authored-by: aweebs <8809837+aweebs@users.noreply.github.com> Due to a regression in npm 9.3.0 (upgraded by Node.JS 18 LTS at 18.14.0, see https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-02-version-18140-hydrogen-lts-bethgriggs-prepared-by-juanarbol), the `npm get config` command stopped working in workspaces. This made our actions using actions/setup-node to fail. Issues were opened in the relevant repositories since january and february (check npm/cli#6099 and actions/setup-node#712) but it looks like getting this fixed upstream it's going to take a long time. We have been waiting for a really long time for other fixes in npm, so I don't expect this situation will be solved really soon We need a working CI before the Vue 3 merge, so applying this commit will solve the issue in the meantime. In the future, it might be interesting to revert this commit. Also format the Gitrhub Actions workflows using the official VSCode GitHub extension
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
Currently all builds are failing the
LintandTypecheck(and other) steps due to an error withsetting up the node environment,
ENOWORKSPACES. From the Lint logs for recent PRs (like #1881):These errors are because the npm cache option doesn't work with npm workspaces - try running
npm config get cachelocally to confirm this. This PR removes the github actions cache option to allow the github action workflows to run.The jobs still fail now because of linting and type checking errors, but the steps actually run to completio.
This should help monitor how PRs increase/decrease lint rule and type checking violations.