Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix failing github action setup #1886

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Commits on Mar 28, 2023

  1. fix: fix failing github actions

    Co-authored-by: aweebs <8809837+aweebs@users.noreply.github.com>
    
    Due to a regression in npm 9.3.0 (upgraded by Node.JS 18 LTS at 18.14.0,
    see https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-02-version-18140-hydrogen-lts-bethgriggs-prepared-by-juanarbol),
    the `npm get config` command stopped working in workspaces. This made
    our actions using actions/setup-node to fail.
    
    Issues were opened in the relevant repositories since january
    and february (check npm/cli#6099 and actions/setup-node#712)
    but it looks like getting this fixed upstream it's going to take a long time.
    We have been waiting for a really long time
    for other fixes in npm, so I don't expect this situation will be solved really soon
    
    We need a working CI before the Vue 3 merge, so applying this commit will
    solve the issue in the meantime. In the future, it might be interesting
    to revert this commit.
    
    Also format the Gitrhub Actions workflows using the official VSCode GitHub extension
    ferferga committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8a61365 View commit details
    Browse the repository at this point in the history