Ability to parse both background and foreground colors. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code of conduct
Changed all refrences from jroimartin to awesome-gocui This fixes issue jroimartin#4
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
Added contributors guide
…oritising view handlers over global handlers
… was causing issues
Trivial typo fix
Fixed readme code example
Change edition mode to editing mode in documentation
Fix build on Windows
This changes matches the general semantics of the methods and can simplify caller code.
Fix a typo in the README Use "reports whether", as is common in many Go docs for functions returning a bool.
It's not my project, but since its own README prominently mentions that it uses gocui, it seems reasonable to backlink here.
A few minor improvements
Pad syscall correctly in getTermWindowSize
The lower bound check was missing; the higher bound check was off by one.
Fix manual bounds checks in View.SetLine
Similar to 036856b (jroimartin#38).
Fix another manual bounds check
* This prevents out-of-bounds errors panics See jesseduffield@3cd3a41 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This is just to be safe See jesseduffield@efab7b0 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* feature/safety: View: Use mutex when clearing View: Use mutex lock when writing Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This might be usefull for people who want to check that See jesseduffield@e030e03 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This might be usefull for people who want to check that See jesseduffield@77d7618 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* Added a handler for tab * Added a handler for space * Added a handler for Insert * Added a handler for Ctrl+U * Added a handler for Ctrl+A * Added a handler for Ctrl+E * Defaults to EditWrite() See jesseduffield@77d7618 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This might be useful for some projects See jesseduffield@bac774b Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* Added Parse() to parse a string to a keybind * Added ParseAll() to parse multiple strings to keybinds * Added MustParse() to parse a string at all costs * Added MustParseAll() to parse multiple strings at all costs * Added an example Co-authored-by: Alex Goodman <wagoodman@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* Allows developers to add / remove keybindings from the blacklist * Added more precise errors * Made the simpleEditor simple again * Added some missing comments Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* feature/utils: Keybinding: Added blacklist / whitelist support Keybinding: Added keybind parsing Gui: Added SetViewBeneath() Edit: Added editor functions View: Added IsTained() View: Added ViewLinesHeight() Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.