Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(postman): fix bluesnap and checkout collections for saved card flow #4071

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Mar 13, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • NMI: Removed Copy from .meta.json to fix Scenario 10 an 11 from running before Scenario 1
  • Bluesnap: Make customer_id unique to avoid payment method from being saved

Closes #4070

Note

.json files are auto-generated

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • NMI (mandates are failing. @Aprabhat19 is looking into it)
    image
    image

  • Bluesnap
    image

  • Checkout
    image

Wrote a script:

image

NMI failed as mentioned above:

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-test Category: Tests labels Mar 13, 2024
@pixincreate pixincreate added this to the March 2024 milestone Mar 13, 2024
@pixincreate pixincreate self-assigned this Mar 13, 2024
@pixincreate pixincreate requested a review from a team as a code owner March 13, 2024 10:26
likhinbopanna
likhinbopanna previously approved these changes Mar 13, 2024
@pixincreate pixincreate changed the title ci(postman): fix bluesnap and nmi collections ci(postman): fix bluesnap and checkout collections for saved card flow Mar 13, 2024
@pixincreate
Copy link
Member Author

image

just so you know, nmi has mandates and removing it is not beneficial in any way.

@likhinbopanna likhinbopanna added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit a21d6d5 Mar 13, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the fix-ci-issues branch March 13, 2024 14:24
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 13, 2024
pixincreate added a commit that referenced this pull request Mar 14, 2024
* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2024.03.13.3
  fix(mandates): give higher precedence to connector mandate id over network txn id in mandates (#4073)
  ci(postman): fix bluesnap and checkout collections for saved card flow (#4071)
  fix: get valid test cards list based on wasm feature config (#4066)
  chore(version): 2024.03.13.2
  fix(payment_methods): set requires-cvv to false for cards in customer payment methods list if making an off-session payment (#4075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug C-test Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix postman collections
3 participants