fix(payment_methods): set requires-cvv to false for cards in customer payment methods list if making an off-session payment #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… payment methods list if making an off-session payment
vspecky
added
A-core
2 tasks
jagan-jaya
approved these changes
Mar 13, 2024
SanchithHegde
approved these changes
Mar 13, 2024
SanchithHegde
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Mar 14, 2024
* 'main' of github.com:juspay/hyperswitch: chore(version): 2024.03.13.3 fix(mandates): give higher precedence to connector mandate id over network txn id in mandates (#4073) ci(postman): fix bluesnap and checkout collections for saved card flow (#4071) fix: get valid test cards list based on wasm feature config (#4066) chore(version): 2024.03.13.2 fix(payment_methods): set requires-cvv to false for cards in customer payment methods list if making an off-session payment (#4075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR updates the logic to decide the
requires_cvvparameter in the customer payment methods list api to also depend on whether the payment is an off-session payment.Additional Changes
Motivation and Context
For off-session payments, the cvv is not required, so it should not be mandatory for off-session payments.
How did you test it?
List Customer Payment Methods for normal payment (requires_cvv = true):
List Customer Payment Methods for off-session payment (requires_cvv = false):
Checklist
cargo +nightly fmt --allcargo clippy