Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mandates): give higher precedence to connector mandate id over network txn id in mandates #4073

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

vspecky
Copy link
Member

@vspecky vspecky commented Mar 13, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently in the core, for a recurring mandate payment, if the mandate has both a network transaction ID and a connector mandate ID associated with it, the core picks the network transaction ID for making the recurring payment. This causes mandate payments to fail since we don't yet have support for making recurring mandate payments using a network transaction ID.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Recurring Mandate payment with Adyen

Initial Mandate Payment:
image

Recurring Mandate payment (Succeeding):
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payments Area: payments labels Mar 13, 2024
@vspecky vspecky added this to the March 2024 milestone Mar 13, 2024
@vspecky vspecky self-assigned this Mar 13, 2024
@vspecky vspecky requested a review from a team as a code owner March 13, 2024 10:30
Narayanbhat166
Narayanbhat166 previously approved these changes Mar 13, 2024
Aprabhat19
Aprabhat19 previously approved these changes Mar 13, 2024
@vspecky vspecky dismissed stale reviews from Aprabhat19 and Narayanbhat166 via 3d32581 March 13, 2024 14:27
@vspecky vspecky requested a review from a team as a code owner March 13, 2024 14:27
@SanchithHegde SanchithHegde merged commit d28e415 into main Mar 13, 2024
10 of 12 checks passed
@SanchithHegde SanchithHegde deleted the fix/mandates-connector-mandate-id-precedence branch March 13, 2024 14:32
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 13, 2024
pixincreate added a commit that referenced this pull request Mar 14, 2024
* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2024.03.13.3
  fix(mandates): give higher precedence to connector mandate id over network txn id in mandates (#4073)
  ci(postman): fix bluesnap and checkout collections for saved card flow (#4071)
  fix: get valid test cards list based on wasm feature config (#4066)
  chore(version): 2024.03.13.2
  fix(payment_methods): set requires-cvv to false for cards in customer payment methods list if making an off-session payment (#4075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payments Area: payments C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Give higher precedence to connector mandate id over network txn id for mandates
5 participants