feat(FEC-10057): move the plugin manager to kaltura player #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
yairans
added a commit
to kaltura/playkit-js
that referenced
this pull request
Aug 5, 2020
* Remove plugin management:
- `PluginManager` and `BasePlugin`
- plugin types and interfaces:
`PKPluginsConfigObject `, `IMiddlewareProvider`, `IPlugin`and `IUIComponentsProvider `
* Remove ads management:
- `Ad` and `adBreak`
- `AdsController` and `ControllerProvider`
- ad types and interfaces:
`PKAdBreakObject`, `PKAdPod`, `PKAdObject`, `PKAdvertisingConfigObject`, `IAdsController`, `IAdsControllerProvider` and `IAdsPluginController`
- advertising and waterfalling management
* Remove `PKUIComponent` and `IUIComponentsProvider`
* Expose `EngineDecorator` registry and the `playbackMiddleware`
* Remove the VR plugin API
* Remove `PLAYBACK_START` and `PLAYBACK_ENDED` firing and handling:
- The [fix](#405) of [FEC-9333](https://kaltura.atlassian.net/browse/FEC-9333) moved to kaltura/playkit-js-ima-dai#41
- The [fix](#440) of [FEC-9534](https://kaltura.atlassian.net/browse/FEC-9534) has been changed to use the `IDLE `state
Solves FEC-10057
Related to kaltura/kaltura-player-js#332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
import the plugin infra and types from kaltura-player
Depends on kaltura/kaltura-player-js#332
Another fix for (FEC-9333) because the current fix relies on
PLAYBACK_ENDEDwhich is irrelevant for playkit anymoreCheckLists