feat(FEC-10057): move the plugin manager to kaltura player #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dan-ziv
previously approved these changes
Jul 14, 2020
|
There is an ad events on playkit which will not be raised when the plugin manager on Kaltura player. |
Yuvalke
reviewed
Aug 5, 2020
| @@ -796,18 +743,6 @@ var config = { | |||
| > | |||
| > ## | |||
| > | |||
| > > ### config.playback.loop | |||
There was a problem hiding this comment.
why did you move loop from playkit to kaltura player?
There was a problem hiding this comment.
since it affected by the PLAYBACK_ENDED event
Yuvalke
previously approved these changes
Aug 5, 2020
yairans
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Aug 5, 2020
* Add plugin management: - `PluginManager` and `BasePlugin` - plugin types and interfaces: `KPPluginsConfigObject `, `IMiddlewareProvider`, `IPlugin`and `IUIComponentsProvider ` * Add ads management: - `Ad` and `adBreak` - `AdsController` and `ControllerProvider` - ad types and interfaces: `KPAdBreakObject`, `KPAdPod`, `KPAdObject`, `KPAdvertisingConfigObject`, `IAdsController`, `IAdsControllerProvider` and `IAdsPluginController` - advertising and waterfalling management * Add `KPUIComponent` and `IUIComponentsProvider` * Add `PLAYBACK_START` and `PLAYBACK_ENDED` firing and handling Solves FEC-10057 Related to kaltura/playkit-js#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Remove plugin management:
PluginManagerandBasePluginPKPluginsConfigObject,IMiddlewareProvider,IPluginandIUIComponentsProviderRemove ads management:
AdandadBreakAdsControllerandControllerProviderPKAdBreakObject,PKAdPod,PKAdObject,PKAdvertisingConfigObject,IAdsController,IAdsControllerProviderandIAdsPluginControllerRemove
PKUIComponentandIUIComponentsProviderExpose
EngineDecoratorregistry and theplaybackMiddlewareRemove the VR plugin API
Remove
PLAYBACK_STARTandPLAYBACK_ENDEDfiring and handling:IDLEstateSolves FEC-10057
Related to kaltura/kaltura-player-js#332
CheckLists