Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9333): when playing a playlist and closing the countdown window, the next entry starts automatically #405

Merged
merged 2 commits into from
Oct 10, 2019
Merged

fix(FEC-9333): when playing a playlist and closing the countdown window, the next entry starts automatically #405

merged 2 commits into from
Oct 10, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 8, 2019 •
edited
Loading

Description of the Changes

  • move to idle when the postroll (dai) is done
  • make sure the engine events fired by the engine itself not by the proxy

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team October 8, 2019 07:21
@yairans yairans self-assigned this Oct 8, 2019
@yairans yairans mentioned this pull request Oct 10, 2019
Closed
5 tasks
@yairans yairans merged commit 2f68bd0 into master Oct 10, 2019
@yairans yairans deleted the FEC-9333 branch October 10, 2019 13:51
This was referenced Jul 28, 2020
Merged
Merged
yairans added a commit that referenced this pull request Aug 5, 2020
@yairans
feat(FEC-10057): move the plugin manager to kaltura player (#463)
59026c0 
* Remove plugin management:
   - `PluginManager` and `BasePlugin`
   - plugin types and interfaces:
   `PKPluginsConfigObject `, `IMiddlewareProvider`, `IPlugin`and `IUIComponentsProvider `
 
* Remove ads management:
   - `Ad` and `adBreak`
   - `AdsController` and `ControllerProvider`
   - ad types and interfaces:
   `PKAdBreakObject`, `PKAdPod`, `PKAdObject`, `PKAdvertisingConfigObject`, `IAdsController`, `IAdsControllerProvider` and `IAdsPluginController`
   - advertising and waterfalling management

* Remove `PKUIComponent` and `IUIComponentsProvider`

* Expose `EngineDecorator` registry and  the `playbackMiddleware` 
* Remove the VR plugin API

* Remove `PLAYBACK_START` and `PLAYBACK_ENDED` firing and handling:
    - The [fix](#405) of [FEC-9333](https://kaltura.atlassian.net/browse/FEC-9333) moved to kaltura/playkit-js-ima-dai#41
    - The [fix](#440) of [FEC-9534](https://kaltura.atlassian.net/browse/FEC-9534) has been changed to use the `IDLE `state

Solves FEC-10057

Related to kaltura/kaltura-player-js#332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe