Improve NewPodControllerForExistingPod to set podReady to true
#2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NewPodControllerForExistingPod` function was supposed to return the podController for an existing pod. If this function is caleld, it would mean that the pod is already runnign and we are creating `podController` for that pod. But this function didn't set `podReady` field of podController to true that was beign checked in some other methods to make sure that the pod is running. And because of that those methods would see the pod to be not running and complain. This commit fixes that by making sure that the pod is running and sets `podReady` to true.
e-sumin
reviewed
Jan 24, 2024
|
LGTM. I'd probably add suggested note to the description. |
e-sumin
approved these changes
Jan 24, 2024
I have added the note @e-sumin . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
NewPodControllerForExistingPodfunction was supposed to return the podController for an existing pod. If this function is caleld, it would mean that the pod is already runnign and we are creatingpodControllerfor that pod.But this function didn't set
podReadyfield of podController to true that was beign checked in some other methods (for exampleGetCommandExecutor) to make sure that the pod is running. And because of that those methods would see the pod to be not running and complain.This PR fixes that by making sure that the pod is running and sets
podReadyto true.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Create podController for an existing pod and make sure we are able to successfully call
GetCommandExecutorthat relies onpodReadyfield.