Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NewPodControllerForExistingPod to set podReady to true #2623

Merged
merged 2 commits into from
Jan 24, 2024

Improve comment to function

539ddfa
Select commit
Loading
Failed to load commit list.
Merged

Improve NewPodControllerForExistingPod to set podReady to true #2623

Improve comment to function
539ddfa
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Jan 24, 2024 in 2s

2 rules match

βœ… Rule: Automatic merge (queue)

  • -draft [πŸ“Œ queue requirement]
  • -mergify-configuration-changed [πŸ“Œ queue -> allow_merging_configuration_change setting requirement]
  • all of:
    • #approved-reviews-by>=1
    • base=master
    • check-success=build (controller)
    • check-success=build (kanctl)
    • check-success=build (kando)
    • check-success=docs
    • check-success=gomod
    • check-success=lint
    • check-success=test (helm-test)
    • check-success=test (integration-test)
    • check-success=test (test)
    • label!="hold off merging"
    • label=kueue
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue default]
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=Summary
        • check-neutral=Summary
        • check-skipped=Summary
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=gomod
        • check-neutral=gomod
        • check-skipped=gomod
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=lint
        • check-neutral=lint
        • check-skipped=lint
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=test (test)
        • check-neutral=test (test)
        • check-skipped=test (test)
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=test (helm-test)
        • check-neutral=test (helm-test)
        • check-skipped=test (helm-test)
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=test (integration-test)
        • check-neutral=test (integration-test)
        • check-skipped=test (integration-test)
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=docs
        • check-neutral=docs
        • check-skipped=docs
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=dependency-review
        • check-neutral=dependency-review
        • check-skipped=dependency-review
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=build (controller)
        • check-neutral=build (controller)
        • check-skipped=build (controller)
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=build (kanctl)
        • check-neutral=build (kanctl)
        • check-skipped=build (kanctl)
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success=build (kando)
        • check-neutral=build (kando)
        • check-skipped=build (kando)

βœ… Rule: delete head branch after merge (delete_head_branch)

  • closed [πŸ“Œ delete_head_branch requirement]
  • merged

πŸ’–Β Β Mergify is proud to provide this service for free to open source projects.

πŸš€Β Β You can help us by becoming a sponsor!


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com