Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NewPodControllerForExistingPod to set podReady to true #2623

Merged
merged 2 commits into from
Jan 24, 2024

Commits on Jan 23, 2024

  1. Improve NewPodControllerForExistingPod to set podReady to true

    `NewPodControllerForExistingPod` function was supposed to return the
    podController for an existing pod. If this function is caleld, it would mean
    that the pod is already runnign and we are creating `podController` for that
    pod.
    But this function didn't set `podReady` field of podController to true that
    was beign checked in some other methods to make sure that the pod is running.
    And because of that those methods would see the pod to be not running and
    complain.
    This commit fixes that by making sure that the pod is running and sets
    `podReady` to true.
    viveksinghggits committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d1398ed View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    539ddfa View commit details
    Browse the repository at this point in the history