Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest new-relic-go v2 client #6325

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

smcavallo
Copy link
Contributor

@smcavallo smcavallo commented Nov 8, 2024

Upgrade to the latest new-relic-go v2 client -> https://github.com/newrelic/newrelic-client-go/releases/tag/v2.51.2
(currently using https://github.com/newrelic/newrelic-client-go/releases/tag/v1.1.0)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo smcavallo requested a review from a team as a code owner November 8, 2024 21:10
Signed-off-by: smcavallo <smcavallo@hotmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Nov 10, 2024

/run-e2e relic
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Could you update the changelog with this change? it's an interesting topic to include under the section Others

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo
Copy link
Contributor Author

Thanks a lot! Could you update the changelog with this change? it's an interesting topic to include under the section Others

Changelog has been updated - thanks!!!!

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JorTurFer
Copy link
Member

JorTurFer commented Nov 11, 2024

/run-e2e relic
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) November 11, 2024 06:56
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

just curious, should we re-run e2e tests since #6326 also merged recently? just to be on the safe side?

@JorTurFer JorTurFer merged commit aae3192 into kedacore:main Nov 11, 2024
19 checks passed
@smcavallo
Copy link
Contributor Author

@wozniakjan - it wouldn't hurt, thanks!!!

@smcavallo smcavallo deleted the newrelic-client-go_v2 branch November 11, 2024 14:26
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants