-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure consistent JSON log format for automaxprocs #6335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great!
Could you please define this in a single place and just reference in each component? The best place is probably a new file in https://github.com/kedacore/keda/tree/main/pkg/util
fixed :) |
/run-e2e internal |
@omerap12 could you please also update Changelog? https://github.com/kedacore/keda/blob/main/CHANGELOG.md#improvements-1 |
Done |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
/run-e2e internal |
Passed. can we merge it? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you move the changelog entry to the unreleased section? after the release it was moved to v2.16 and should be unreleased yet
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
hope I did it right this time lol |
/skip-e2e |
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: michael pechner <mike.pechner@akasa.com>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Configures automaxprocs to use the application logger instead of default console logging to maintain consistent JSON format across all log output.
output:
keda-operator:
keda-operator-metrics-apiserver:
Checklist
Fixes #5970