-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute_from_outside #1246
Merged
ClementWalter
merged 55 commits into
kkrt-labs:main
from
ClementWalter:cw/execute-from-outside
Jul 17, 2024
Merged
Add execute_from_outside #1246
ClementWalter
merged 55 commits into
kkrt-labs:main
from
ClementWalter:cw/execute-from-outside
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
ClementWalter
commented
Jul 2, 2024
Todo:
|
ClementWalter
commented
Jul 2, 2024
Todo:
|
tcoratger
reviewed
Jul 2, 2024
enitrat
reviewed
Jul 3, 2024
ClementWalter
commented
Jul 3, 2024
ClementWalter
commented
Jul 3, 2024
ClementWalter
commented
Jul 3, 2024
ClementWalter
commented
Jul 3, 2024
obatirou
force-pushed
the
cw/execute-from-outside
branch
2 times, most recently
from
July 3, 2024 13:31
af0382b
to
148463c
Compare
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
ClementWalter
commented
Jul 4, 2024
Co-authored-by: Clément Walter <clement0walter@gmail.com>
ClementWalter
force-pushed
the
cw/execute-from-outside
branch
from
July 16, 2024 17:13
36c3b24
to
fa7c156
Compare
7 tasks
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
rm StoredTransactionHash and transaction_hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the SNIP9 entrypoint
Todo
accounts.library.validate
to get the signature in argument and not fromtx_info
__validate__
and__execute__
usageAccount_cairo1_helpers_class_hash
add get class fromKakarot.get_cairo1_helpers_class_hash()
Account.validate
the logic from Interpreter.execute (see here)Snippet to send a tx with relayer in python
Resolves: #1240
This change is