Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add animations to JourneyCard and SavedTripsScreen #268

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 30, 2024

TL;DR

Added animations to journey cards and saved trip cards for a smoother user experience.

What changed?

  • Implemented animateContentSize() and animateDpAsState() for the JourneyCard component to smoothly transition between default and expanded states.
  • Added an animation to the SavedTripCard in the SavedTripsScreen using animateItem() with a fade-out effect.
  • Removed the animateContentSize() from the JourneyCard in the TimeTableScreen.

Why make this change?

These animations enhance the overall user experience by providing visual feedback and creating a more polished look and feel for the app. The smooth transitions make the interface more engaging and intuitive for users when interacting with journey and saved trip cards.

@ksharma-xyz ksharma-xyz changed the title Animate items in list UI: Add animations to JourneyCard and SavedTripsScreen Oct 30, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 30, 2024 11:21
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Oct 30, 2024 — with Graphite App
Base automatically changed from 10-30-fix_saved_trip_update_was_not_updating_ui_on_deleting_the_last_item to main October 30, 2024 13:35
@ksharma-xyz ksharma-xyz force-pushed the 10-30-animate_items_in_list branch from 12b4fb0 to cfd4657 Compare October 30, 2024 13:36
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 30, 2024 13:36
@ksharma-xyz ksharma-xyz merged commit 5aa716c into main Oct 30, 2024
3 checks passed
@ksharma-xyz ksharma-xyz deleted the 10-30-animate_items_in_list branch October 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant