UI: Add star icon toggle and refactor TitleBar actions #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
ksharma-xyz
force-pushed
the
10-31-display_stop_names_on_timetable_screen
branch
from
69ea28b to
9d13ca2
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
6bedcd2 to
d51ffe6
Compare
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
10-31-display_stop_names_on_timetable_screen
branch
from
9d13ca2 to
3c286e3
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
d51ffe6 to
36b1bab
Compare
This was referenced Oct 31, 2024
ksharma-xyz
force-pushed
the
10-31-display_stop_names_on_timetable_screen
branch
from
3c286e3 to
f557002
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
36b1bab to
1fe3fd1
Compare
ksharma-xyz
force-pushed
the
10-31-display_stop_names_on_timetable_screen
branch
2 times, most recently
from
34d3dd6 to
67d3814
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
1fe3fd1 to
db4ce93
Compare
ksharma-xyz
changed the base branch from
10-31-display_stop_names_on_timetable_screen
to
graphite-base/272
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
db4ce93 to
8cbc12e
Compare
ksharma-xyz
force-pushed
the
graphite-base/272
branch
from
67d3814 to
0680fb1
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
8cbc12e to
c4de318
Compare
Merge activity
|
ksharma-xyz
deleted the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added star outline icon and updated title bar to support save/unsave trip functionality.
What changed?
star_outline.xmldrawable and renamed existing star icon tostar_filled.xmlTitleBarcomponent to support action buttonsdisassembledNameinstead ofnameWhy make this change?
To provide users with a more intuitive way to save and unsave trips directly from the TimeTable screen's title bar, improving the overall user experience and making the save functionality more discoverable.