Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update theme colors and add trip details to TimeTableScreen #270

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 30, 2024

TL;DR

Updated UI components to use surface colors and improved the time table screen with trip details.

What changed?

  • Changed RoundIconButton and TextFieldButton to use surface colors instead of secondary container colors
  • Added trip details (from/to stations) to the TimeTableScreen with location icons
  • Updated SavedTripCard background colors to use transport mode theming
  • Modified placeholder text in text fields to be more descriptive
  • Added trip information to TimeTableState

Why make this change?

To improve visual consistency across the app by standardizing the use of surface colors and to enhance the user experience by displaying more detailed trip information in the time table view. The changes also better align with Material Design guidelines for surface treatments and provide clearer input field labels for users.

@ksharma-xyz ksharma-xyz force-pushed the 10-30-add_tripinfo_to_timetablescreen branch from 573ce0e to 3b11c9c Compare October 30, 2024 13:49
@ksharma-xyz ksharma-xyz force-pushed the 10-30-update_theming_-_temporary branch from d0e5847 to 88e0837 Compare October 30, 2024 13:52
@ksharma-xyz ksharma-xyz force-pushed the 10-30-add_tripinfo_to_timetablescreen branch from 3b11c9c to 9104238 Compare October 31, 2024 04:14
@ksharma-xyz ksharma-xyz changed the title Update theming - temporary UI: Update theme colors and add trip details to TimeTableScreen Oct 31, 2024
@ksharma-xyz ksharma-xyz force-pushed the 10-30-add_tripinfo_to_timetablescreen branch from 9104238 to 1861095 Compare October 31, 2024 04:19
@ksharma-xyz ksharma-xyz force-pushed the 10-30-update_theming_-_temporary branch from 88e0837 to 4938ad0 Compare October 31, 2024 04:20
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 31, 2024 04:21
@ksharma-xyz ksharma-xyz changed the base branch from 10-30-add_tripinfo_to_timetablescreen to graphite-base/270 October 31, 2024 04:30
@ksharma-xyz ksharma-xyz force-pushed the 10-30-update_theming_-_temporary branch from 4938ad0 to 4ffc2e7 Compare October 31, 2024 04:31
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/270 to main October 31, 2024 04:31
@ksharma-xyz ksharma-xyz force-pushed the 10-30-update_theming_-_temporary branch from 4ffc2e7 to 9df8bd8 Compare October 31, 2024 04:31
@ksharma-xyz ksharma-xyz merged commit 41f358c into main Oct 31, 2024
3 checks passed
Copy link
Owner Author

Merge activity

  • Oct 31, 12:41 AM EDT: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 10-30-update_theming_-_temporary branch October 31, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant