-
Notifications
You must be signed in to change notification settings - Fork 172
Compute NumSourceObjects in HNCConfiguration status #546
Conversation
Note: This PR is implemented on top of kubernetes-retired#542, please review that first. I will rebase and remove the hold once kubernetes-retired#542 is merged. Thank you! This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of objects of a specific type created by users. Tested:unit tests, GKE cluster Issue: kubernetes-retired#411 initial commit
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sophieliu15 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I will cancel hold once #542 is merged. |
/assign @adrianludwin |
Unfortunately I don't have enough time to resolve conflicts in this file. :( I will resolve the conflicts and clean it up after I come back from vacation. |
np! |
@sophieliu15: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unassign @adrianludwin |
This PR is replaced by #584 Close this PR for now. |
Note: This PR is implemented on top of #542, please review that first. I will rebase and remove the hold once #542 is merged. Thank you!
This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of objects of a specific type created by users.
Tested:unit tests, GKE cluster
Issue: #411