Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Compute NumSourceObjects in HNCConfiguration status #546

Closed

Conversation

sophieliu15
Copy link
Contributor

Note: This PR is implemented on top of #542, please review that first. I will rebase and remove the hold once #542 is merged. Thank you!

This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of objects of a specific type created by users.

Tested:unit tests, GKE cluster

Issue: #411

Note: This PR is implemented on top of kubernetes-retired#542, please review that first. I will rebase and remove the hold once kubernetes-retired#542 is merged. Thank you!

This PR computes NumSourceObjects as a part of HNCConfiguration status. NumSourceObjects indicates the number of objects of a specific type created by users.

Tested:unit tests, GKE cluster

Issue: kubernetes-retired#411

initial commit
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sophieliu15
To complete the pull request process, please assign srampal
You can assign the PR to them by writing /assign @srampal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Fei-Guo and tashimi March 24, 2020 17:37
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 24, 2020
@sophieliu15
Copy link
Contributor Author

/hold

I will cancel hold once #542 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@sophieliu15
Copy link
Contributor Author

/assign @adrianludwin
/assign @yiqigao217

@sophieliu15 sophieliu15 changed the title Compute NumPropagatedObjects in HNCConfiguration status Compute NumSourceObjects in HNCConfiguration status Mar 26, 2020
@sophieliu15
Copy link
Contributor Author

Unfortunately I don't have enough time to resolve conflicts in this file. :( I will resolve the conflicts and clean it up after I come back from vacation.

@adrianludwin
Copy link
Contributor

Unfortunately I don't have enough time to resolve conflicts in this file. :( I will resolve the conflicts and clean it up after I come back from vacation.

np!

@k8s-ci-robot
Copy link
Contributor

@sophieliu15: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
@sophieliu15
Copy link
Contributor Author

/unassign @adrianludwin
/unassign @yiqigao217

@sophieliu15
Copy link
Contributor Author

This PR is replaced by #584

Close this PR for now.

@sophieliu15 sophieliu15 closed this Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants