Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update app K8s dependencies #687

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jan 4, 2024

What this PR does / why we need it:

This is part of splitting out changes from #684 in smaller increments. make test passes successfully locally on this change set

...
--- PASS: TestGetIdentityFromSTSResponse (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Root_User (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/User (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Role (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Federated_User (0.00s)
PASS
coverage: 75.7% of statements
ok  	sigs.k8s.io/aws-iam-authenticator/pkg/token	1.442s	coverage: 75.7% of statements
go tool cover -html=coverage.out -o coverage.html

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 4, 2024
@jyotimahapatra
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2024
@jyotimahapatra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@bryantbiggs
Copy link
Member Author

/retest

@bryantbiggs
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 4, 2024
@bryantbiggs bryantbiggs force-pushed the chore/update-app-k8s-dependencies branch from 993becf to 2464b9d Compare January 5, 2024 01:32
@bryantbiggs
Copy link
Member Author

bryantbiggs commented Jan 8, 2024

struggling to figure out this ginkgo error:

 Unknown Decorator
var _ = Describe("[apiserver] the apiserver", framework.WithDisruptive(), func() {
/home/prow/go/src/github.com/kubernetes-sigs/aws-iam-authenticator/tests/e2e/apiserver_test.go:44
  [Container] node was passed an unknown decorator:
  'framework.label{parts:[]string{"Disruptive"}, extra:""}'
  Learn more at: http://onsi.github.io/ginkgo/#node-decorators-overview

Which was previously:

ERROR: E2E suite initialization was faulty, these errors must be fixed:
ERROR: apiserver_test.go:44: [Disruptive] in plain text is deprecated and must be added through WithDisruptive instead

@bryantbiggs
Copy link
Member Author

cc @jyotimahapatra if you get a moment to re-review, thank you!


When("the manifest changes", func() {
BeforeEach(func() {
cfg, _ = clientcmd.BuildConfigFromFlags("", framework.TestContext.KubeConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for familiarity: is this not needed because f := framework.NewDefaultFramework("apiserver") is added above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! I'm not well versed in the testing framework but upstream has made several ergonomic improvements so now the config and client set can be extracted from the framework itself

@@ -69,3 +69,6 @@ cscope.*
# coverage.out file
coverage.out
coverage.html

# multi-module workspaces
go.work*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: did we multi module workspace for a needed functionality?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, I don't know the full implications of adding this to the project. but my IDE was failing to resolve paths without the multi-module workspace setup so I added it to work locally but that creates a go.work (that looks like below) and a go.work.sum. I'm happy to go any way with this - revert the change to the gitignore, keep it, add the go.work* files, etc.

// go.work
go 1.21

use (
	./tests/e2e
	./tests/integration
)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on kubernetes/enhancements#4402 - perhaps we do not want to ignore the go workspaces and instead start utilizing them?

@bryantbiggs
Copy link
Member Author

bryantbiggs commented Jan 19, 2024

@jyotimahapatra / @nnmin-aws let me know if there are any other comments or feedback that I can help address, thank you!

@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@wongma7
Copy link
Contributor

wongma7 commented Apr 22, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7007017 into kubernetes-sigs:master Apr 22, 2024
6 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-app-k8s-dependencies branch April 22, 2024 17:59
@bryantbiggs bryantbiggs mentioned this pull request Apr 25, 2024
jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024
…app-k8s-dependencies

chore: Update app K8s dependencies
jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024
…app-k8s-dependencies

chore: Update app K8s dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE: PRISMA-2022-0227 in emicklei/go-restful/v3
6 participants