-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update app K8s dependencies #687
chore: Update app K8s dependencies #687
Conversation
Hi @bryantbiggs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/retest |
/retest |
993becf
to
2464b9d
Compare
…gh WithDisruptive instead
struggling to figure out this ginkgo error:
Which was previously:
|
cc @jyotimahapatra if you get a moment to re-review, thank you! |
|
||
When("the manifest changes", func() { | ||
BeforeEach(func() { | ||
cfg, _ = clientcmd.BuildConfigFromFlags("", framework.TestContext.KubeConfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for familiarity: is this not needed because f := framework.NewDefaultFramework("apiserver")
is added above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! I'm not well versed in the testing framework but upstream has made several ergonomic improvements so now the config and client set can be extracted from the framework itself
@@ -69,3 +69,6 @@ cscope.* | |||
# coverage.out file | |||
coverage.out | |||
coverage.html | |||
|
|||
# multi-module workspaces | |||
go.work* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: did we multi module workspace for a needed functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest, I don't know the full implications of adding this to the project. but my IDE was failing to resolve paths without the multi-module workspace setup so I added it to work locally but that creates a go.work
(that looks like below) and a go.work.sum
. I'm happy to go any way with this - revert the change to the gitignore, keep it, add the go.work*
files, etc.
// go.work
go 1.21
use (
./tests/e2e
./tests/integration
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on kubernetes/enhancements#4402 - perhaps we do not want to ignore the go workspaces and instead start utilizing them?
@jyotimahapatra / @nnmin-aws let me know if there are any other comments or feedback that I can help address, thank you! |
/lgtm |
/lgtm |
… into chore/update-app-k8s-dependencies
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryantbiggs, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…app-k8s-dependencies chore: Update app K8s dependencies
…app-k8s-dependencies chore: Update app K8s dependencies
What this PR does / why we need it:
This is part of splitting out changes from #684 in smaller increments.
make test
passes successfully locally on this change setWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #