-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update app K8s dependencies #687
Merged
k8s-ci-robot
merged 14 commits into
kubernetes-sigs:master
from
bryantbiggs:chore/update-app-k8s-dependencies
Apr 22, 2024
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b9a669a
chore: Update app K8s dependencies
bryantbiggs 0b8771f
fix: Downgrade `k8s.io/sample-controller` which requires updating con…
bryantbiggs ec140f7
fix: Integration test dependencies run `go mod tidy`
bryantbiggs a66aaea
fix: Fix codegen and update `replace` test integration dependencies
bryantbiggs bac75be
fix: Align integration test `replace` versions in `go.mod`
bryantbiggs 5c3b5a5
fix: Add context to `StartTestServer`
bryantbiggs 2464b9d
chore: Update dependencies for `e2e` tests
bryantbiggs acbfad3
fix: [Disruptive] in plain text is deprecated and must be added throu…
bryantbiggs 6c94ad6
fix: Use `framework.WithDisruptive()`
bryantbiggs 8a34c65
fix: Use `SIGDescribe`
bryantbiggs d872c1f
feat: Re-update K8s packages to latest release
bryantbiggs 3fa67f1
chore: Re-update and align
bryantbiggs 309922a
chore: Re-update to latest patch version of K8s packages
bryantbiggs 4ac7942
Merge branch 'master' of github.com:bryantbiggs/aws-iam-authenticator…
bryantbiggs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,3 +69,6 @@ cscope.* | |
# coverage.out file | ||
coverage.out | ||
coverage.html | ||
|
||
# multi-module workspaces | ||
go.work* | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: did we multi module workspace for a needed functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest, I don't know the full implications of adding this to the project. but my IDE was failing to resolve paths without the multi-module workspace setup so I added it to work locally but that creates a
go.work
(that looks like below) and ago.work.sum
. I'm happy to go any way with this - revert the change to the gitignore, keep it, add thego.work*
files, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on kubernetes/enhancements#4402 - perhaps we do not want to ignore the go workspaces and instead start utilizing them?