-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang.org/x/tools from 0.9.3 to 0.11.0 in /hack/tools #9063
Comments
/help |
@killianmuldoon: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted Thx for opening the issue |
Maybe we can make it configurable in some way (worst case env var) |
Yeah - we could add it as a variable passed into the command where release link is called, but it would break other users any way we make this a requirement. Depends on how much value we see in maintaining this tool properly - we could deprecate the public version and move a more tightly coupled version into an internal package. |
As a bit of extra contest - this is currently used in Cluster API providers for AWS, Cloudstack, IBMCloud and Openstack in public kubernetes sigs repos - https://cs.k8s.io/?q=sigs.k8s.io%2Fcluster-api%2Fhack%2Ftools%2Fmdbook%2Freleaselink&i=nope&files=&excludeFiles=&repos= |
Note: Once we did this we have to enable dependabot for this dependency again: #9109 (comment) @killianmuldoon Please add this as a task to the issue description |
/assign |
The dependabot PR to update golang.org/x/tools from 0.9.3 to 0.11.0 resulted in a deprecation warning which caused the linter to fail with
Related bump: #9052
The entire VCS package, which is used in the release link tool to translate the go module into the github URL, has been deprecated and AFAIU there is no replacement package. The advice is to use go list, but I don't know how this can be used in this case.
An alternative would be to take the parts of the code we need from the VCS package and keep them as part of the release link tool.
Fundamentally what we need is a way to map the go module to the URL location of the repo. This tool is used in other projects - at least in CAPA from a quick browse - so we can't simply hardcode the URL.
Using
sigs.k8s.io/cluster-api
as the base of the URL does not work for downloading release artifacts i.e.https://sigs.k8s.io/cluster-api/releases
redirects tohttps://github.com/kubernetes-sigs/cluster-api/blob/main/releases
Tasks
The text was updated successfully, but these errors were encountered: