Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ : Remove go-vcs dependency from releaselink tool #9288

Merged

Conversation

killianmuldoon
Copy link
Contributor

Add a required "repo" tag to passed into usages of the releaselink tool. This is required in order to get rid of the deprecated "golang.org/x/tools/go/vcs"

This is a breaking change for downstream users of this tool who will have to add the new var - but it seemed simpler and easier to maintain than copying over the module -> repo resolution code from the go VCS tool.

Fixes #9063

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 23, 2023
@killianmuldoon killianmuldoon changed the title ⚠️ : Remove go-vcs dependency from releaselink binary ⚠️ : Remove go-vcs dependency from releaselink tool Aug 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2023
@killianmuldoon killianmuldoon force-pushed the pr-remove-go-vcs-dep branch 3 times, most recently from d10b3eb to 57abb96 Compare August 23, 2023 12:59
@killianmuldoon
Copy link
Contributor Author

/area util

@k8s-ci-robot k8s-ci-robot added area/util Issues or PRs related to utils and removed do-not-merge/needs-area PR is missing an area label labels Aug 23, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area

docs/book/src/user/quick-start.md Show resolved Hide resolved
@sbueringer
Copy link
Member

/lgtm

+/- migration note

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: be9c0b98e9fffad448b17a81b3e34b5b2c1d2d25

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@killianmuldoon
Copy link
Contributor Author

Added a note.

@sbueringer
Copy link
Member

Thx!

/lgtm

I assume when the repo tag is not added the book generation will just fail pretty hard? (with the errors we return)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b27ff83554fd29d291ef7839873a90e9b9eee8d

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@killianmuldoon
Copy link
Contributor Author

I assume when the repo tag is not added the book generation will just fail pretty hard? (with the errors we return)

Yeah - mdbook fails with an error locally. I've pushed a failing commit to ensure this also happens in CI.

@killianmuldoon
Copy link
Contributor Author

/hold

For failing commit

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@killianmuldoon
Copy link
Contributor Author

Link to CI result when not using the tag: https://app.netlify.com/sites/kubernetes-sigs-cluster-api/deploys/64e61eacf90b8f000814236d

I've removed the failing commit now.

@sbueringer
Copy link
Member

Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b27ff83554fd29d291ef7839873a90e9b9eee8d

@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit e13c1e5 into kubernetes-sigs:main Aug 23, 2023
29 of 30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump golang.org/x/tools from 0.9.3 to 0.11.0 in /hack/tools
3 participants