-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump sigs.k8s.io/controller-tools from 0.12.1 to 0.13.0 in /hack/tools #9281
🌱 Bump sigs.k8s.io/controller-tools from 0.12.1 to 0.13.0 in /hack/tools #9281
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Let's merge the CR bump first I tried to bump this in the CR PR but somehow it then also bumps golang.org/x/tools (#9063) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
30bbfa9
to
c9546a3
Compare
@killianmuldoon That's the same issue I got locally when trying to bump ct as part of the cr bump. Basically the new CT version seems to trigger the problem with the tools module |
I've assigned myself the issue - will try to get it closed out. |
Thank you very much! |
#9288 should unblock this PR |
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.12.1 to 0.13.0. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.12.1...v0.13.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c9546a3
to
e157a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: d86e973217ba5477ecfd6e699f0e13e135854572
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
Bumps sigs.k8s.io/controller-tools from 0.12.1 to 0.13.0.
Release notes
Sourced from sigs.k8s.io/controller-tools's releases.
Commits
d89d6ae
Merge pull request #832 from sbueringer/pr-bump-k-1.2802a4e5c
Bump to k/k v0.28.0498444b
Merge pull request #841 from kubernetes-sigs/dependabot/go_modules/golang.org...e747d1b
🌱 Bump golang.org/x/tools from 0.11.1 to 0.12.0d18ba5c
Merge pull request #810 from shyamradhakrishnan/shyamradhakrishnan-fix-8090089762
Merge pull request #840 from kubernetes-sigs/dependabot/go_modules/golang.org...17720f8
🌱 Bump golang.org/x/tools from 0.11.0 to 0.11.1c94980b
Merge pull request #838 from kubernetes-sigs/dependabot/go_modules/github.com...7d12792
🌱 Bump github.com/onsi/gomega from 1.27.9 to 1.27.101d54c6c
Merge pull request #836 from kubernetes-sigs/dependabot/go_modules/github.com...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name> dependency
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name> dependency
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions