🏃 ff release-0.2 to master #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration work was already done to move controller-runtime from k8s v1.13 to v1.14, however this introduced certain issues. Unfortunately, workqueue_queue_duration_seconds and workqueue_work_duration_seconds were included in v0.1.10, but were recorded with microsecond values. Moving to k8s v1.14 corrects those values to seconds. Primarily this change removes the metrics that were deprecated in k8s v1.14, but were never previously included in v0.1 of controller-runtime. The one metric that was deprecated and is retained is longest_running_processor_microseconds, as it was included in v0.1.10.
🐛 remove deprecated workqueue metrics with invalid names
🐛Pass appropriate context to leaderelector.Run
⚠️ make UseExistingCluster a pointer to support explicitly op…
📖 minor updates to the examples
…ollers If a kind has implemented Defaulter and(or) Validator interface(s), multiple controllers for this kind should be able to be added to the same controller manager.
🐛 stop registering webhooks with same path when adding multiple controllers
pkg/runtime/scheme was supposed to maintain a type alias to make it easier for people to upgrade and/or interact with projects written around older versions, but apparently, I forgot to actually leave the type alias around. This fixes that.
✨ Fix runtime/scheme type aliases
🐛 update jsonpatch
Controller builder now only build controller; while webhook builder only build webhook.
⚠️ split the webhook builder out as a separate builder.
Main changes: - Disable conversion webhook by default and enable only if a type implements convertible - Enhanced the test coverage to include spoke to spoke conversion
✨ enable conversion webhook in webhook builder
✨ Fix typo
k8s-ci-robot
added
cncf-cla: yes
droot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare to next CR beta release which is necessary for kubebuilder.